Skip to content

Commit 895ae2a

Browse files
authored
Merge pull request #388 from jgilbert01/issue-claimcheck-incorrect-entry-request
Fix request entry.
2 parents 71d1c37 + df12071 commit 895ae2a

File tree

4 files changed

+24
-23
lines changed

4 files changed

+24
-23
lines changed

package-lock.json

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "aws-lambda-stream",
3-
"version": "1.0.26",
3+
"version": "1.0.27",
44
"description": "Create stream processors with AWS Lambda functions.",
55
"keywords": [
66
"aws",

src/utils/batch.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,11 @@ export const batchWithSize = ({
7777
logMetrics([x], [size], opt);
7878
if (claimCheckBucketName) {
7979
// setup claim check
80-
x[putClaimcheckRequest] = toPutClaimcheckRequest(x[opt.requestEntryField], claimCheckBucketName);
81-
x[opt.requestEntryField] = toClaimcheckEvent(x[opt.requestEntryField], claimCheckBucketName);
80+
x[putClaimcheckRequest] = toPutClaimcheckRequest(JSON.parse(x[opt.requestEntryField].Detail), claimCheckBucketName);
81+
x[opt.requestEntryField].Detail = JSON.stringify(toClaimcheckEvent(
82+
JSON.parse(x[opt.requestEntryField].Detail),
83+
claimCheckBucketName,
84+
));
8285
size = Buffer.byteLength(JSON.stringify(x[opt.requestEntryField]));
8386
} else {
8487
const error = new Error(`Request size: ${size}, exceeded max: ${opt.maxRequestSize}`);

test/unit/sinks/claimcheck.test.js

+16-18
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,27 @@ describe('sinks/claimcheck.js', () => {
1717
const spy = sinon.spy();
1818
const uows = [
1919
{
20-
publishRequestEntry: { // size = 23
21-
id: '1',
22-
body: 'xxx',
20+
publishRequestEntry: {
21+
Detail: JSON.stringify({ // size = 23
22+
id: '1',
23+
body: 'xxx',
24+
}),
2325
},
2426
},
2527
{
26-
publishRequestEntry: { // size = 33
27-
id: '2',
28-
body: 'xxxxxxxxxxxxx',
28+
publishRequestEntry: {
29+
Detail: JSON.stringify({ // size = 33
30+
id: '2',
31+
body: 'xxxxxxxxxxxxx',
32+
}),
2933
},
3034
},
3135
{
32-
publishRequestEntry: { // size = 140
33-
id: '3',
34-
body: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx',
36+
publishRequestEntry: {
37+
Detail: JSON.stringify({ // size = 140
38+
id: '3',
39+
body: 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx',
40+
}),
3541
},
3642
},
3743
];
@@ -52,15 +58,7 @@ describe('sinks/claimcheck.js', () => {
5258
expect(collected[1]).to.deep.equal([
5359
{
5460
publishRequestEntry: { // size = 39
55-
id: '3',
56-
type: undefined,
57-
partitionKey: undefined,
58-
timestamp: undefined,
59-
tags: undefined,
60-
s3: {
61-
bucket: 'event-lake-s3',
62-
key: 'us-west-2/claimchecks/2024/8/20/17/3',
63-
},
61+
Detail: '{"id":"3","s3":{"bucket":"event-lake-s3","key":"us-west-2/claimchecks/2024/8/20/17/3"}}',
6462
},
6563
putClaimcheckRequest: {
6664
Bucket: 'event-lake-s3',

0 commit comments

Comments
 (0)