fixed downstream project, problem with test_spblas.f90

Since module uses mkl_spblas.mod that is precompiled... a potential
problem could be the fact that the .mod file is not compiled properly
and is therefore leading to a seg fault when calling functions from
`use mkl_spblas`.... the test_spblas.f90 DOES work when you
just include mkl_spblas.f90 directly instead of going through
the include directories...

Author: Jared Frazier

cmake/HelloSPBLASConfig.cmake.in

@@ -2,22 +2,26 @@
 @PACKAGE_INIT@
 
 # from libiconmath 
-# note test-drive/template.cmake and fftpack/config/CMakeLists.txt uses IF guard)
+# note test-drive/template.cmake and fftpack/install/CMakeLists.txt uses IF guard)
 include("${CMAKE_CURRENT_LIST_DIR}/@[email protected]")
 
 include(CMakeFindDependencyMacro)
-if(${ENABLE_FFTPACK})
+if(@ENABLE_FFTPACK@)
     find_dependency(fftpack REQUIRED)
 endif()
 
-if(${ENABLE_PFUNIT})
+if(@ENABLE_PFUNIT@)
     find_dependency(PFUNIT REQUIRED)
 endif()
 
-if (${ENABLE_TEST_DRIVE})
+if (@ENABLE_TEST_DRIVE@)
     find_dependency(test-drive REQUIRED)
 endif()
 
+if (@ENABLE_FIND_INTEL_MKL@)
+    find_dependency(MKL REQUIRED)
+endif()
+
 include(FindPackageHandleStandardArgs)
 find_package_handle_standard_args(
     @PROJECT_NAME@ REQUIRED_VARS @PROJECT_NAME@_DIR

cmake/helper.cmake

@@ -24,7 +24,7 @@ function(link_spblas targ)
         # Specify the MKL libraries for linking
         target_link_libraries(
             ${targ}
-            PRIVATE
+            PUBLIC
                 # must be static 
                 ${MKLLIB}/libmkl_blas95_ilp64.a
 

config/intel_ubuntu_spblas

@@ -7,7 +7,7 @@ cmake -S . -B build-spblas\
     -DCMAKE_Fortran_COMPILER=ifx\
     -DBUILD_TESTING=ON\
     -DENABLE_SPBLAS=ON\
-    -DENABLE_FIND_INTEL_MKL=ON
+    -DENABLE_FIND_INTEL_MKL=OFF
 cmake --build build-spblas
 ./build-spblas/test/test_spblas 
 [[ -n $builddocs ]] && cmake --build build-spblas --target doxygen_docs 

config/intel_ubuntu_test_drive

@@ -6,13 +6,16 @@ curdir=$(pwd)
 [[ $curdir == *"config"* ]] && echo "must be in root project dir" && exit 1 
 #[[ -d build ]] && rm -rf build
 cmake -S . -B build\
+    -DCMAKE_Fortran_COMPILER=ifx\
     -DBUILD_TESTING=ON\
-    -DENABLE_SPBLAS=OFF\
-    -DENABLE_PFUNIT=OFF\
     -DENABLE_TEST_DRIVE=ON\
-    -DCMAKE_Fortran_COMPILER=ifx\
+    -DENABLE_FFTPACK=ON\
+    -DENABLE_SPBLAS=ON\
+    -DENABLE_FIND_INTEL_MKL=OFF\
+    -DENABLE_PFUNIT=OFF\
     -DCMAKE_INSTALL_PREFIX=build/installed
 cmake --build build
+cmake --build build --target install
 cd build
 # name from test/CMakeLists.txt build_tests(FIRST_ARG ...)
 ctest -R test_drive_square_tests

src/CMakeLists.txt

@@ -30,7 +30,7 @@ target_include_directories(${PROJECT_NAME} PUBLIC
 
 if(${ENABLE_FFTPACK})
     target_compile_definitions(${PROJECT_NAME} PRIVATE FFTPACK)
-    target_link_libraries(${PROJECT_NAME} PRIVATE fftpack)
+    target_link_libraries(${PROJECT_NAME} PUBLIC fftpack)
 endif()
 
 if(${ENABLE_SPBLAS})

test/downstream_project/hello.f90

@@ -1,9 +1,9 @@
 ! Use external library HelloSPBLAS 
 PROGRAM main
-    USE mo_square, ONLY: square 
+    USE mo_square, ONLY: sum_cube_square
     REAL :: x = 2 
     REAL :: y
     PRINT *, "Hello, world!"   
-    y = square(x)
-    PRINT *, "square(x) =", y
+    y = sum_cube_square(x)
+    PRINT *, y
 END PROGRAM main 

test/test_spblas.f90

@@ -16,30 +16,33 @@
 !
 ! In the MKL Cookbook (cookbook_index.htm) many different example problems are
 ! solved... could use that also as a reference.
-INCLUDE "mkl_spblas.f90"
+include "mkl_spblas.f90" ! TODO: remove this!
 PROGRAM TEST_SPBLAS
+    USE, INTRINSIC :: ISO_C_BINDING, ONLY: C_FLOAT, C_INT, C_LONG
     USE mkl_spblas, ONLY: sparse_matrix_t, matrix_descr, &
         mkl_sparse_s_create_csr, mkl_sparse_s_create_coo, mkl_sparse_s_mv, &
         SPARSE_INDEX_BASE_ONE, SPARSE_MATRIX_TYPE_GENERAL, &
         SPARSE_OPERATION_NON_TRANSPOSE
 
     IMPLICIT NONE
 
-    INTEGER, PARAMETER :: rows = 4
-    INTEGER, PARAMETER :: cols = 6
+    INTEGER(KIND=C_INT), PARAMETER :: rows = 4
+    INTEGER(KIND=C_INT), PARAMETER :: cols = 6
 
-    INTEGER, PARAMETER :: nnz = 8
+    INTEGER(KIND=C_INT), PARAMETER :: nnz = 8
 
-    INTEGER :: ia(rows+1), ja(nnz), stat
-    REAL :: values(nnz), x(6), y(4), y_coo(4)
+    !INTEGER(KIND=C_INT) :: ia(rows+1), ja(nnz)
+    INTEGER(KIND=C_LONG) :: ia(rows+1), ja(nnz)
+    INTEGER :: stat
+    REAL(KIND=C_FLOAT) :: values(nnz), x(6), y(4), y_coo(4)
 
     TYPE(sparse_matrix_t) :: a
     TYPE(matrix_descr) :: descr
 
     TYPE(sparse_matrix_t) :: A_coo
 
-    INTEGER, ALLOCATABLE :: row_indx(:)     
-    INTEGER, ALLOCATABLE :: col_indx(:) 
+    INTEGER(KIND=C_INT), ALLOCATABLE :: row_indx(:)     
+    INTEGER(KIND=C_INT), ALLOCATABLE :: col_indx(:) 
 
     ! Matrix example taken from: 
     ! https://en.wikipedia.org/wiki/Sparse_matrix#Compressed_sparse_row_(CSR,_CRS_or_Yale_format)
@@ -49,6 +52,7 @@ PROGRAM TEST_SPBLAS
     !     |  0   0 50 60 70  0 |
     !     |  0   0  0  0  0 80 | 
 
+    ! create:
     ! create csr
     ia = [1,3,5,8,9]
     ja = [1,2,2,4,3,4,5,6]
@@ -60,23 +64,24 @@ PROGRAM TEST_SPBLAS
     print *, "stat create = ", stat
     descr%type = SPARSE_MATRIX_TYPE_GENERAL
 
-    ! create coo
-    row_indx = [1, 1, 2, 2, 3, 3, 3, 4] 
-    col_indx = [1, 2, 2, 4, 3, 4, 5, 6]
-    stat = mkl_sparse_s_create_coo(&
-        A_coo, SPARSE_INDEX_BASE_ONE, rows, cols, nnz, row_indx, col_indx,&
-        values) 
+    !! create coo
+    !row_indx = [1, 1, 2, 2, 3, 3, 3, 4] 
+    !col_indx = [1, 2, 2, 4, 3, 4, 5, 6]
+    !stat = mkl_sparse_d_create_coo(&
+        !A_coo, SPARSE_INDEX_BASE_ONE, rows, cols, nnz, row_indx, col_indx,&
+        !values) 
 
-    ! spmv csr 
+    ! spmv: 
     x = [1,1,1,1,1,1]
+    ! spmv csr 
     stat = mkl_sparse_s_mv(SPARSE_OPERATION_NON_TRANSPOSE,1.0,a,descr,x,0.0,y)
     print *, "stat mv = ", stat
     print *, "result csr  = ", y
     print *, "expected = ", [30., 70., 180., 80.]
 
-    ! spmv coo
-    stat = mkl_sparse_s_mv(&
-        SPARSE_OPERATION_NON_TRANSPOSE, 1.0, A_coo, descr, x, 0.0, y_coo)
-    print *, "result coo  = ", y_coo
+    !! spmv coo
+    !stat = mkl_sparse_d_mv(&
+        !SPARSE_OPERATION_NON_TRANSPOSE, 1.0, A_coo, descr, x, 0.0, y_coo)
+    !print *, "result coo  = ", y_coo
 
 END PROGRAM TEST_SPBLAS