Replace "switch" statements with callback function tables

Signed-off-by: Jack Cherng <[email protected]>

Author: jfcherng

src/Renderer/Html/Inline.php

@@ -95,33 +95,17 @@ protected function renderTableSeparateBlock(): string
      */
     protected function renderTableBlock(array $change): string
     {
-        $html = '<tbody class="change change-' . self::TAG_CLASS_MAP[$change['tag']] . '">';
-
-        switch ($change['tag']) {
-            default:
-            // equal changes should be shown on both sides of the diff
-            case SequenceMatcher::OP_EQ:
-                $html .= $this->renderTableEqual($change);
-
-                break;
-            // added lines only on the r side
-            case SequenceMatcher::OP_INS:
-                $html .= $this->renderTableInsert($change);
-
-                break;
-            // show deleted lines only on the l side
-            case SequenceMatcher::OP_DEL:
-                $html .= $this->renderTableDelete($change);
-
-                break;
-            // show modified lines on both sides
-            case SequenceMatcher::OP_REP:
-                $html .= $this->renderTableReplace($change);
-
-                break;
-        }
+        static $callbacks = [
+            SequenceMatcher::OP_EQ => 'renderTableEqual',
+            SequenceMatcher::OP_INS => 'renderTableInsert',
+            SequenceMatcher::OP_DEL => 'renderTableDelete',
+            SequenceMatcher::OP_REP => 'renderTableReplace',
+        ];
 
-        return $html . '</tbody>';
+        return
+            '<tbody class="change change-' . self::TAG_CLASS_MAP[$change['tag']] . '">' .
+                $this->{$callbacks[$change['tag']]}($change) .
+            '</tbody>';
     }
 
     /**

src/Renderer/Html/SideBySide.php

@@ -93,33 +93,17 @@ protected function renderTableSeparateBlock(): string
      */
     protected function renderTableBlock(array $change): string
     {
-        $html = '<tbody class="change change-' . self::TAG_CLASS_MAP[$change['tag']] . '">';
-
-        switch ($change['tag']) {
-            default:
-            // equal changes should be shown on both sides of the diff
-            case SequenceMatcher::OP_EQ:
-                $html .= $this->renderTableEqual($change);
-
-                break;
-            // added lines only on the r side
-            case SequenceMatcher::OP_INS:
-                $html .= $this->renderTableInsert($change);
-
-                break;
-            // show deleted lines only on the l side
-            case SequenceMatcher::OP_DEL:
-                $html .= $this->renderTableDelete($change);
-
-                break;
-            // show modified lines on both sides
-            case SequenceMatcher::OP_REP:
-                $html .= $this->renderTableReplace($change);
-
-                break;
-        }
+        static $callbacks = [
+            SequenceMatcher::OP_EQ => 'renderTableEqual',
+            SequenceMatcher::OP_INS => 'renderTableInsert',
+            SequenceMatcher::OP_DEL => 'renderTableDelete',
+            SequenceMatcher::OP_REP => 'renderTableReplace',
+        ];
 
-        return $html . '</tbody>';
+        return
+            '<tbody class="change change-' . self::TAG_CLASS_MAP[$change['tag']] . '">' .
+                $this->{$callbacks[$change['tag']]}($change) .
+            '</tbody>';
     }
 
     /**