nits

Signed-off-by: Jack Cherng <[email protected]>

Author: jfcherng

src/Factory/RendererFactory.php

@@ -72,13 +72,10 @@ public static function resolveTemplate(string $template): ?string
     {
         static $cache = [];
 
-        // the result could be null so do not use isset() here
-        if (\array_key_exists($template, $cache)) {
+        if (isset($cache[$template])) {
             return $cache[$template];
         }
 
-        $result = null;
-
         foreach (RendererConstant::TEMPLATE_TYPES as $type) {
             $className = RendererConstant::RENDERER_NAMESPACE . "\\{$type}\\{$template}";
 
@@ -89,6 +86,6 @@ public static function resolveTemplate(string $template): ?string
             }
         }
 
-        return $cache[$template] = $result;
+        return isset($result) ? ($cache[$template] = $result) : null;
     }
 }

src/Renderer/Html/LineRenderer/Line.php

@@ -14,7 +14,7 @@ final class Line extends AbstractLineRenderer
      */
     public function render(MbString $mbFrom, MbString $mbTo): LineRendererInterface
     {
-        [$start, $end] = $this->getChangedExtentBeginEnd($mbFrom, $mbTo);
+        [$start, $end] = $this->getChangedExtentRegion($mbFrom, $mbTo);
 
         // two strings are the same
         if ($end === 0) {
@@ -46,7 +46,7 @@ public function render(MbString $mbFrom, MbString $mbTo): LineRendererInterface
      * @return array Array containing the starting position (non-negative) and the ending position (negative)
      *               [0, 0] if two strings are the same
      */
-    protected function getChangedExtentBeginEnd(MbString $mbFrom, MbString $mbTo): array
+    protected function getChangedExtentRegion(MbString $mbFrom, MbString $mbTo): array
     {
         // two strings are the same
         // most lines should be this cases, an early return could save many function calls
@@ -56,19 +56,19 @@ protected function getChangedExtentBeginEnd(MbString $mbFrom, MbString $mbTo): a
 
         // calculate $start
         $start = 0;
-        $startLimit = \min($mbFrom->strlen(), $mbTo->strlen());
+        $startMax = \min($mbFrom->strlen(), $mbTo->strlen());
         while (
-            $start < $startLimit && // index out of range
+            $start < $startMax && // index out of range
             $mbFrom->getAtRaw($start) === $mbTo->getAtRaw($start)
         ) {
             ++$start;
         }
 
         // calculate $end
         $end = -1; // trick
-        $endLimit = $startLimit - $start;
+        $endMin = $startMax - $start;
         while (
-            -$end <= $endLimit && // index out of range
+            -$end <= $endMin && // index out of range
             $mbFrom->getAtRaw($end) === $mbTo->getAtRaw($end)
         ) {
             --$end;