Skip to content

Commit 15e2fb1

Browse files
authored
fix: pass a ctx to client searcher search (#2495)
## Summary This allows to cancel the search request. ## How was it tested? Mostly manual testing
1 parent c3cab01 commit 15e2fb1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

internal/boxcli/search.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ func searchCmd() *cobra.Command {
3333
query := args[0]
3434
name, version, isVersioned := searcher.ParseVersionedPackage(query)
3535
if !isVersioned {
36-
results, err := searcher.Client().Search(query)
36+
results, err := searcher.Client().Search(cmd.Context(), query)
3737
if err != nil {
3838
return err
3939
}

internal/searcher/client.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func Client() *client {
3232
}
3333
}
3434

35-
func (c *client) Search(query string) (*SearchResults, error) {
35+
func (c *client) Search(ctx context.Context, query string) (*SearchResults, error) {
3636
if query == "" {
3737
return nil, fmt.Errorf("query should not be empty")
3838
}
@@ -43,7 +43,7 @@ func (c *client) Search(query string) (*SearchResults, error) {
4343
}
4444
searchURL := endpoint + "?q=" + url.QueryEscape(query)
4545

46-
return execGet[SearchResults](context.TODO(), searchURL)
46+
return execGet[SearchResults](ctx, searchURL)
4747
}
4848

4949
// Resolve calls the /resolve endpoint of the search service. This returns

0 commit comments

Comments
 (0)