Skip to content

Commit 03673e2

Browse files
anchoulsonewhl
authored andcommitted
Fixed comments
1 parent d6a41df commit 03673e2

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

ExtractingCode/WhatIsExtractVariableRefactoring/ExtractMagicConstantsPractice/test/ExtractMagicNumbersTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
public class ExtractMagicNumbersTest extends BaseIjTestClass {
1212

1313
private static String sourceText;
14+
private static final String SPEED_OF_LIGHT = "299792458.0";
15+
private static final String PLANCK_CONSTANT = "6.62607015e-34";
1416

1517
@BeforeAll
1618
static void beforeAll() throws IOException {
@@ -24,12 +26,10 @@ static void beforeAll() throws IOException {
2426
public void testExtractedConstant() throws Exception {
2527
setUp();
2628
myFixture.configureByText("Task.java", sourceText);
27-
String speedOfLight = "299792458.0";
28-
Assertions.assertTrue(hasConstantWithGivenValue(speedOfLight),
29-
"Please, create constant values for " + speedOfLight);
30-
String planckConstant = "6.62607015e-34";
31-
Assertions.assertTrue(hasConstantWithGivenValue(planckConstant),
32-
"Please, create constant values for " + planckConstant);
29+
Assertions.assertTrue(hasConstantWithGivenValue(SPEED_OF_LIGHT),
30+
"Please, create constant values for " + SPEED_OF_LIGHT);
31+
Assertions.assertTrue(hasConstantWithGivenValue(PLANCK_CONSTANT),
32+
"Please, create constant values for " + PLANCK_CONSTANT);
3333
String propertyName = "waveLength";
3434
Assertions.assertTrue(hasLocalVariable(propertyName),
3535
"Please, create property for " + propertyName);

MovingCode/WhatArePullUpAndPushDownRefactorings/ApplyPullUpRefactoringPractice/task-info.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
type: edu
22
custom_name: Apply Pull Up refactoring
33
files:
4-
- name: src/main/java/jetbrains/refactoring/course/moving/Animal.java
5-
visible: true
64
- name: src/main/java/jetbrains/refactoring/course/moving/Cat.java
75
visible: true
6+
- name: src/main/java/jetbrains/refactoring/course/moving/Animal.java
7+
visible: true
88
- name: src/main/java/jetbrains/refactoring/course/moving/Dog.java
99
visible: true
1010
- name: test/PullUpTest.java
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
type: edu
22
custom_name: Find more appropriate classes for methods
33
files:
4+
- name: src/main/java/jetbrains/refactoring/course/moving/driver/Driver.java
5+
visible: true
46
- name: src/main/java/jetbrains/refactoring/course/moving/Main.java
57
visible: true
68
- name: src/main/java/jetbrains/refactoring/course/moving/car/Car.java
79
visible: true
8-
- name: src/main/java/jetbrains/refactoring/course/moving/driver/Driver.java
9-
visible: true
1010
- name: test/MovingMethodsTest.java
1111
visible: false

MovingCode/WhatIsMoveMethodRefactoring/FindMoreAppropriateFilesForClassesPractice/test/MovingTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@ public void testCarClassMoved() throws Exception {
2929
setUp();
3030
myFixture.configureByText("Car.java", carText);
3131
Assertions.assertTrue(hasClass("Car"),
32-
"Please, move the Car class to a separate file");
32+
"Please, move the Car class to a separate file in the car package");
3333
}
3434

3535
@Test
3636
public void testDriverClassMoved() throws Exception {
3737
setUp();
3838
myFixture.configureByText("Driver.java", driverText);
3939
Assertions.assertTrue(hasClass("Driver"),
40-
"Please, move the Driver class to a separate file");
40+
"Please, move the Driver class to a separate file in the driver package");
4141
}
4242
}

0 commit comments

Comments
 (0)