Merge pull request #233 from jetbrains-academy/konstantin/modules_feedback_improvements

Improvements of Modules lesson according to feedback

Author: kochaika

Modules and packages/Built-in modules/task.md

@@ -20,7 +20,7 @@ secondary prompts if the interpreter is in the interactive mode:
 The variable `sys.path` is a list of strings that determines the interpreter’s search path 
 for modules: see what it prints for you when you run the code of the task.
 
-Remember that you can use &shortcut:CodeCompletion; after a dot (.) to explore available 
+Remember that you can use the &shortcut:CodeCompletion; shortcut after a dot (.) to explore available 
 methods of a module. You can read more about standard modules <a href="https://docs.python.org/3/tutorial/modules.html#standard-modules">here</a>.
 
 For more structured and detailed information, you can also refer to [this Hyperskill knowledge base page](https://hyperskill.org/learn/step/6019#built-in-modules?utm_source=jba&utm_medium=jba_courses_links).  

Modules and packages/From import/task-info.yaml

@@ -1,9 +1,5 @@
 type: edu
 files:
-- name: my_module.py
-  visible: true
-- name: calculator.py
-  visible: true
 - name: from_import.py
   visible: true
   placeholders:
@@ -13,6 +9,10 @@ files:
   - offset: 97
     length: 12
     placeholder_text: '''Instantiate a calculator'''
+- name: my_module.py
+  visible: true
+- name: calculator.py
+  visible: true
 - name: tests/__init__.py
   visible: false
 - name: tests/test_task.py

Modules and packages/Import module/task-info.yaml

@@ -0,0 +1,3 @@
+import my_funcs
+
+my_funcs.hello_world("John")

Modules and packages/Import_module/imports.py

@@ -0,0 +1,16 @@
+type: edu
+custom_name: Import module
+files:
+  - name: imports.py
+    visible: true
+    placeholders:
+      - offset: 26
+        length: 19
+        placeholder_text: '# call the hello_world function from the my_funcs module'
+  - name: my_funcs.py
+    visible: true
+  - name: tests/__init__.py
+    visible: false
+  - name: tests/test_task.py
+    visible: false
+feedback_link: https://docs.google.com/forms/d/e/1FAIpQLSfRlDlldKfuq-cHMNFfHMER61P1PRIan7KG6yp1GvaweDI7GA/viewform?usp=pp_url&entry.2103429047=Modules+and+Packages+/+Import+module

Modules and packages/Import module/my_module.py renamed to Modules and packages/Import_module/my_funcs.py

@@ -16,19 +16,13 @@ directly, but using the module name, you can now access the functions, for examp
 ```python
 my_funcs.func1()
 ```
-
-Modules can import other modules. It is customary but not required to place all 
-import statements at the beginning of a module.
-
-You can find out more about modules in Python by reading [this section](https://docs.python.org/3/tutorial/modules.html) of The Python Tutorial. 
 
 For more structured and detailed information, you can also refer to [this Hyperskill knowledge base page](https://hyperskill.org/learn/step/6019#module-loading?utm_source=jba&utm_medium=jba_courses_links).
 
 ### Task
-In the code editor, import the module `calculator` and create an instance of the class `Calculator` (`calc`). 
-Use the `add` method defined in `Calculator` in a loop to add up numbers from 0 to 99.
+In the code editor, you have already imported the module `my_funcs`. 
+Call the function `hello_world` from this module with the argument `"John"`.
 
-<div class='hint'>Use the <code>import</code> keyword and the <code>calculator</code> reference.</div>
 <div class='hint'>Access the function from the module using syntax such as <code>module.function()</code>.</div>
 <div class="hint">Don't forget to provide the function with an argument.</div>
 

Modules and packages/Import_module/task-info.yaml

@@ -0,0 +1,20 @@
+import unittest
+import contextlib
+import io
+import re
+
+f = io.StringIO()
+try:
+    with contextlib.redirect_stdout(f):
+        from imports import *
+    output = f.getvalue().split('\n')
+
+    class TestCase(unittest.TestCase):
+        def test_out(self):
+            expected, actual = 'Hello, World! My name is John', output[0]
+            self.assertEqual(expected, actual, msg='Call hello_world with the "John" argument.')
+
+except AttributeError:
+    class TestFailCase(unittest.TestCase):
+        def test_fail(self):
+            self.assertTrue(False, msg='You need to use the hello_world function from the my_funcs module.')