Skip to content

Slim Dependencies #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpojer opened this issue Jan 25, 2017 · 13 comments
Closed

Slim Dependencies #2691

cpojer opened this issue Jan 25, 2017 · 13 comments

Comments

@cpojer
Copy link
Member

cpojer commented Jan 25, 2017

Also see facebook/create-react-app#1183

We should focus on reducing the amount of dependencies that are shipped with Jest. Is there somebody that could do an analysis?

@wtgtybhertgeghgtwtg
Copy link
Contributor

wtgtybhertgeghgtwtg commented Jan 26, 2017

I thought I was dreaming when I saw this issue.

@cpojer
Copy link
Member Author

cpojer commented Jan 26, 2017

ah, it sucks that all of these are transitive dependencies and that we don't really have much control over it.

@kentcdodds
Copy link
Contributor

Can I just say that @wtgtybhertgeghgtwtg's analysis is incredibly thorough. Thank you for doing that

giphy

@orta
Copy link
Member

orta commented Jan 26, 2017

Yep, this is really great work - thanks @wtgtybhertgeghgtwtg

@cpojer
Copy link
Member Author

cpojer commented Jan 27, 2017

note-notifier dropped the cli: #2718

@JaKXz
Copy link

JaKXz commented Jan 29, 2017

The istanbul-reports PR has been merged and released! 😃

@cpojer
Copy link
Member Author

cpojer commented Jan 29, 2017

Nice!

@wtgtybhertgeghgtwtg
Copy link
Contributor

Just an overview of the impact this has had.
[email protected] is about seven dependencies and one megabyte lighter than [email protected]. Here's a comparison of the node_modules of a fresh install of the two (Windows 10, [email protected])
jest 18 1 0 vs jest 19 0 0

@cpojer
Copy link
Member Author

cpojer commented Feb 21, 2017

Nice work, thanks @wtgtybhertgeghgtwtg for working on this and getting back with more data :)

@mhart
Copy link

mhart commented Mar 14, 2017

It was lighter until request v2.80.0 went ahead and destroyed all the gains:

http://pkgsize.com/jest.html (select an area to zoom in and hover to see the event that caused the change)

which is largely:

http://pkgsize.com/jest-cli.html

The big ones there are:

@sanyatuning
Copy link

+1

@cpojer
Copy link
Member Author

cpojer commented Dec 15, 2017

I think we are mostly good on this for now and we sped Jest's startup up by more than 50% with Jest 21. If anybody wants to drop more stuff, please feel free to comment here and send PRs!

@cpojer cpojer closed this as completed Dec 15, 2017
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants