Skip to content

What should we do in the new major #574

Closed
@G-Rath

Description

@G-Rath

Just making this meta issue to consolidate what we'd like to land in/around the new major, since we've made some comments in different places:

Depending on time, we could try to do #482.

(I don't think we're in any major rush, since we're not actually blocking anything re jest 26 or eslint 7 - I could be wrong there?)

@SimenB made some comments too:

  • Dropping eslint 5 support (👍)
  • Use the suggestions api for things, such as:
    • toStrictEqual - personally I'm happy with that remaining an autofix, because running your tests should tell you if it's actually changed a behaviour (which is also why I wondered if maybe it should be recommended - it strikes me as a bit like == vs ===?)
    • no-test-callback should use a suggestion as it's dangerous to autofix
  • Renaming no-test-callback to no-done-callback as it's a more accurate name (👍)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions