-
Notifications
You must be signed in to change notification settings - Fork 684
Open
Labels
enhancementAn improvementAn improvement
Description
I see now just a simple string concatenation of directory_p
and specifier
:
jerryscript/jerry-core/api/jerry-module.c
Lines 141 to 161 in 0d49696
const jerry_char_t *directory_p = lit_get_magic_string_utf8 (LIT_MAGIC_STRING__EMPTY); | |
jerry_size_t directory_size = lit_get_magic_string_size (LIT_MAGIC_STRING__EMPTY); | |
jerry_module_t *module_p = jerry_object_get_native_ptr (referrer, &jerry_module_native_info); | |
if (module_p != NULL) | |
{ | |
directory_p = module_p->path_p; | |
directory_size = module_p->basename_offset; | |
} | |
jerry_size_t specifier_size = jerry_string_size (specifier, JERRY_ENCODING_UTF8); | |
jerry_size_t reference_size = directory_size + specifier_size; | |
jerry_char_t *reference_path_p = jerry_heap_alloc (reference_size + 1); | |
memcpy (reference_path_p, directory_p, directory_size); | |
jerry_string_to_buffer (specifier, JERRY_ENCODING_UTF8, reference_path_p + directory_size, specifier_size); | |
reference_path_p[reference_size] = '\0'; | |
jerry_char_t *path_p = jerry_port_path_normalize (reference_path_p, reference_size); | |
jerry_heap_free (reference_path_p, reference_size + 1); |
Does this mean that scenarios like absolute paths cannot be handled? My proposal for this is to add a parameter to jerry_port_path_normalize
that specifies directory_size
(which is also an offset to specifier
).
Metadata
Metadata
Assignees
Labels
enhancementAn improvementAn improvement