table_select plugin looses returning clause

[fnordfish]

My "artists" table doesn't use an auto increment PK, but feed from a singe sequence.

For demonstration purposes lets use a "UUID" but not the uuid plugin, so that we rely on server generated values.

DB.create_table(:artists) do
  column :id, "UUID", primary_key: true, default: Sequel.function("UUID")
end

class Artist < Sequel::Model
end

Creating a row via the model class works just as expected:

Artist.create
# BEGIN
# INSERT INTO `artists` () VALUES () RETURNING *
# COMMIT

But with with the table_select plugin, the RETURNING part is missing and falling back to LAST_INSERT_ID:

Artist.plugin :table_select
Artist.create
# INFO: (0.000314s) BEGIN
# INFO: (0.000457s) INSERT INTO `artists` () VALUES ()
# ERROR: Trilogy::ProtocolError: 4078: Illegal parameter data types uuid and int for operation '=' (trilogy_query_recv): SELECT * FROM `artists` WHERE `id` = 0
# INFO: (0.000473s) ROLLBACK

Additionally using the insert_returning_select only works in combination with the column_select:

# starting over
class Artist < Sequel::Model; end
Artist.plugin :column_select
Artist.plugin :insert_returning_select
Artist.create
# INFO: (0.000181s) BEGIN
# INFO: (0.000371s) INSERT INTO `artists` () VALUES () RETURNING `id`
# INFO: (0.000677s) COMMIT
# => #<Artist @values={id: "b3aab495-b0b3-11f0-b267-da1c9c23eca5"}>

Say, I wouldn't want column_select and insert_returning_select, is there a way to get the table_select plugin not loosing the RETURNING clause?

[jeremyevans]

I think the better solution in this case would be to make insert_returning_select handle SELECT table.* and use RETURNING *. I'll work on that.

[jeremyevans]

Change made in 6538c2a, can you test it out and report whether it works for you?

[fnordfish]

Works for me. Not sure if that's intentional, but the RETURNING lists all columns, instead if *.
Weirdly, works in a minimal setup.. I'll investigate if it's some other plugin

[fnordfish]

When I additionally add the prepared_statements plugin, the RETURNING clause changes from * to the list of columns.

[jeremyevans]

That's expected, the prepared_statements handles RETURNING itself. As documented, the prepared_statements plugin exists for backwards compatibility and is not recommended for general use.

[fnordfish]

That makes sense. Thanks! It probably slipped confusing it with https://sequel.jeremyevans.net/rdoc/files/doc/prepared_statements_rdoc.html