Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not add favorite currency list #26

Open
simlegate opened this issue Apr 28, 2022 · 6 comments
Open

can not add favorite currency list #26

simlegate opened this issue Apr 28, 2022 · 6 comments

Comments

@simlegate
Copy link

simlegate commented Apr 28, 2022

It's correct to setup base currency.
image
But it seem to can not recognize this command curcon LIST.
image
Is there some wrong operation for me?

Node: v17.9.0
Alfred: 4.6.4 Powerpack
alfred-currency-conversion: 0.2.0

@simlegate
Copy link
Author

It seems that the new feature Set your own favorite currency list is not included in version 0.2.0.
Is there deadline to release new version?

@MartinMalinda
Copy link

Yes, when I install this it seems like the code is quite different from master. I don't get the favoriteCurrencies.

I hover made this change in the source:

const topCurrencies = process.env['CURRENCIES'] ?
  process.env['CURRENCIES'].split(',') :
  ["USD", "EUR", "JPY", "GBP", "CHF", "CAD", "AUD"];
const allCurrencies = ["AUD", "BGN", "BRL", "CAD", "CHF", "CNY", "CZK", "DKK", "EUR", "GBP", "HKD", "HRK", "HUF", "IDR", "ILS", "INR", "ISK", "JPY", "KRW", "MXN", "MYR", "NOK", "NZD", "PHP", "PLN", "RON", "RUB", "SEK", "SGD", "THB", "TRY", "USD", "ZAR"];
const currencies = [...new Set([...topCurrencies, ...allCurrencies])];

And I set comma separated currencies in environment variables and that works for me.
I guess I might lose this change on update but I don't mind that much.

@lidoror
Copy link

lidoror commented Jul 26, 2022

how can I paste it into the workflow?

@MartinMalinda
Copy link

Screenshot 2022-07-26 at 9 31 03
Screenshot 2022-07-26 at 9 31 46

There you can find the source. Good luck!

@lidoror
Copy link

lidoror commented Jul 26, 2022

did you replaced all three variable for it to work?

@MartinMalinda
Copy link

MartinMalinda commented Jul 26, 2022

yes! I also set an environmenta variable

Screen.Recording.2022-07-26.at.11.12.23.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants