Fix #10 "toString() on fresh SyslogMessageSenders causes NPE"

Author: cyrille-leclerc

src/main/java/com/cloudbees/syslog/sender/AbstractSyslogMessageSender.java

@@ -136,7 +136,7 @@ public void setDefaultSeverity(Severity defaultSeverity) {
 
     @Override
     public String toString() {
-        return "AbstractSyslogMessageSender{" +
+        return getClass().getName() + "{" +
                 "defaultAppName='" + defaultAppName + '\'' +
                 ", defaultFacility=" + defaultFacility +
                 ", defaultMessageHostname='" + defaultMessageHostname + '\'' +

src/main/java/com/cloudbees/syslog/sender/TcpSyslogMessageSender.java

@@ -202,8 +202,10 @@ public void setSyslogServerPort(int syslogServerPort) {
         this.syslogServerPort = syslogServerPort;
     }
 
+    @Nullable
     public String getSyslogServerHostname() {
-        return syslogServerHostnameReference.get().getHostName();
+        InetAddress inetAddress = syslogServerHostnameReference.get();
+        return inetAddress == null ? null : inetAddress.getHostName();
     }
 
     public int getSyslogServerPort() {
@@ -240,7 +242,7 @@ public void setMaxRetryCount(int maxRetryCount) {
 
     @Override
     public String toString() {
-        return "TcpSyslogMessageSender{" +
+        return getClass().getName() + "{" +
                 "syslogServerHostname='" + this.getSyslogServerHostname() + '\'' +
                 ", syslogServerPort='" + this.getSyslogServerPort() + '\'' +
                 ", ssl=" + ssl +

src/main/java/com/cloudbees/syslog/sender/UdpSyslogMessageSender.java

@@ -120,11 +120,29 @@ public void setSyslogServerPort(int syslogServerPort) {
         this.syslogServerPort = syslogServerPort;
     }
 
+    @Nullable
     public String getSyslogServerHostname() {
-        return syslogServerHostnameReference.get().getHostName();
+        InetAddress inetAddress = syslogServerHostnameReference.get();
+        return inetAddress == null ? null : inetAddress.getHostName();
     }
 
     public int getSyslogServerPort() {
         return syslogServerPort;
     }
+
+    @Override
+    public String toString() {
+        return getClass().getName() + "{" +
+                "syslogServerHostname='" + this.getSyslogServerHostname() + '\'' +
+                ", syslogServerPort='" + this.getSyslogServerPort() + '\'' +
+                ", defaultAppName='" + defaultAppName + '\'' +
+                ", defaultFacility=" + defaultFacility +
+                ", defaultMessageHostname='" + defaultMessageHostname + '\'' +
+                ", defaultSeverity=" + defaultSeverity +
+                ", messageFormat=" + messageFormat +
+                ", sendCounter=" + sendCounter +
+                ", sendDurationInNanosCounter=" + sendDurationInNanosCounter +
+                ", sendErrorCounter=" + sendErrorCounter +
+                '}';
+    }
 }