Skip to content

Commit 168162e

Browse files
author
Cyrille Le Clerc
committed
Fix #19 NullPointerException in TcpSyslogMessageSender#toString()
1 parent ae70a1f commit 168162e

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

src/main/java/com/cloudbees/syslog/sender/TcpSyslogMessageSender.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,8 @@ public void setSyslogServerPort(int syslogServerPort) {
206206

207207
@Nullable
208208
public String getSyslogServerHostname() {
209+
if (syslogServerHostnameReference == null)
210+
return null;
209211
InetAddress inetAddress = syslogServerHostnameReference.get();
210212
return inetAddress == null ? null : inetAddress.getHostName();
211213
}

src/test/java/com/cloudbees/syslog/sender/TcpSyslogMessageSenderTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,4 +92,12 @@ public void sendOverSSL() throws Exception {
9292
}
9393

9494

95+
/**
96+
* https://github.com/CloudBees-community/syslog-java-client/issues/19
97+
*/
98+
@Test
99+
public void test_bug19_NullPointerException_In_ToString(){
100+
TcpSyslogMessageSender tcpSyslogMessageSender = new TcpSyslogMessageSender();
101+
tcpSyslogMessageSender.toString();
102+
}
95103
}

0 commit comments

Comments
 (0)