update to support breaking change in github-api (#772)

* update to support breaking change in github-api

The method gitHttpTransportUrl has been removed from github-api (see commit hub4j/github-api@944d92b?diff=split). And because of that the ghprb plugin is broken. This change correct the issue.

* Update pom.xml

* update deps

* try to correct maven enforcer plugin failures

* update deps

* retriggering build

* correct unit tests

* update style check to remove windows specific erros

Co-authored-by: Lajugie, Julien <[email protected]>

Author: JulienLajugie

checkstyle.xml

@@ -43,7 +43,9 @@
 
     <!-- Checks whether files end with a new line.                        -->
     <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
-    <module name="NewlineAtEndOfFile"/>
+    <module name="NewlineAtEndOfFile">
+        <property name="lineSeparator" value="lf" />
+    </module>
 
     <!-- Checks that property files contain the same keys.         -->
     <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->

pom.xml

@@ -136,7 +136,7 @@
         <dependency>
             <groupId>org.jenkins-ci.plugins</groupId>
             <artifactId>github-api</artifactId>
-            <version>1.90</version>
+            <version>1.92</version>
         </dependency>
         <dependency>
             <groupId>org.jenkins-ci.plugins</groupId>

src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java

@@ -719,7 +719,7 @@ public String getAuthorRepoGitUrl() {
         String authorRepoGitUrl = "";
 
         if (prHead != null && prHead.getRepository() != null) {
-            authorRepoGitUrl = prHead.getRepository().gitHttpTransportUrl();
+            authorRepoGitUrl = prHead.getRepository().getHttpTransportUrl();
         }
         return authorRepoGitUrl;
     }

src/test/java/org/jenkinsci/plugins/ghprb/GhprbPullRequestTest.java

@@ -218,7 +218,7 @@ public void authorRepoGitUrlShouldBeSetWhenRepository() throws Exception {
         // GIVEN
         String expectedAuthorRepoGitUrl = "https://github.com/jenkinsci/ghprb-plugin";
         GHRepository repository = mock(GHRepository.class);
-        given(repository.gitHttpTransportUrl()).willReturn(expectedAuthorRepoGitUrl);
+        given(repository.getHttpTransportUrl()).willReturn(expectedAuthorRepoGitUrl);
 
         given(head.getRepository()).willReturn(repository);