Skip to content

Commit 8291572

Browse files
committed
stale: removed stale log lines. update: version in pom. README with logo
1 parent d0aa897 commit 8291572

File tree

9 files changed

+10
-20
lines changed

9 files changed

+10
-20
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<p align="center">
2+
<a href="https://browserstack.com"><img alt="BrowserStack Logo" src="https://d98b8t1nnulk5.cloudfront.net/production/images/layout/logo-invoice.svg"></a>
3+
</p>
4+
15
# Overview
26
[BrowserStack](https://browserstack.com) gives instant access to 2000+ real mobile devices and browsers that enables developers to test their websites and mobile applications without requiring to install or maintain an internal lab of virtual machines, devices, or emulators.
37

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</parent>
1111

1212
<artifactId>browserstack-integration</artifactId>
13-
<version>1.1.10-SNAPSHOT</version>
13+
<version>1.2.0</version>
1414
<packaging>hpi</packaging>
1515

1616
<name>BrowserStack</name>
@@ -150,7 +150,7 @@
150150
<dependency>
151151
<groupId>com.browserstack</groupId>
152152
<artifactId>automate-client-java</artifactId>
153-
<version>0.6</version>
153+
<version>0.7</version>
154154
</dependency>
155155

156156
<dependency>

src/main/java/com/browserstack/automate/ci/common/proxysettings/JenkinsProxySettings.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import java.net.URL;
1414

1515
import static com.browserstack.automate.ci.common.logger.PluginLogger.log;
16-
import static com.browserstack.automate.ci.common.logger.PluginLogger.logError;
16+
import static com.browserstack.automate.ci.common.logger.PluginLogger.logDebug;
1717

1818
public class JenkinsProxySettings {
1919

@@ -79,9 +79,8 @@ private URL verifyAndGetProxyURL(final String proxyString, final String proxyTyp
7979

8080
return proxyUrl;
8181
} catch (Exception e) {
82-
// TODO: Change to logDebug
8382
if (logger != null)
84-
logError(logger, String.format("Invalid Proxy String: %s, Proxy Type: %s. Error: %s", proxyString, proxyType, e.toString()));
83+
logDebug(logger, String.format("Invalid Proxy String: %s, Proxy Type: %s. Error: %s", proxyString, proxyType, e.toString()));
8584
return null;
8685
}
8786
}
@@ -129,9 +128,6 @@ private void decideJenkinsProxy(final String customProxyString) {
129128
this.finalProxyUsername = jarProxyUser;
130129
this.finalProxyPassword = jarProxyPassword;
131130
}
132-
133-
if (this.finalProxyUsername == null)
134-
System.out.println("Username is null in case of JAR proxy...");
135131
}
136132

137133
// Utilises the proxyUrl set by Env Vars if Jenkins & Jar Proxy are absent
@@ -180,6 +176,7 @@ private String getSystemProxyString() {
180176

181177
/**
182178
* Returns Jenkins proxy configuration in Proxy object
179+
*
183180
* @return Proxy object
184181
*/
185182
public Proxy getJenkinsProxy() {

src/main/java/com/browserstack/automate/ci/common/tracking/PluginsTracker.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
public class PluginsTracker {
2626
private static final MediaType JSON = MediaType.get("application/json; charset=utf-8");
2727
private static final String URL = "https://api.browserstack.com/ci_plugins/track";
28-
private transient OkHttpClient client;
2928
private final String trackingId;
29+
private transient OkHttpClient client;
3030
private String username;
3131
private String accessKey;
3232
private String customProxy;
@@ -77,16 +77,13 @@ private void initializeClient() {
7777

7878
JenkinsProxySettings jenkinsProxy;
7979
if (customProxy != null) {
80-
System.out.println("Custom Proxy In Plugins Tracker: " + customProxy);
8180
jenkinsProxy = new JenkinsProxySettings(customProxy, null);
8281
} else {
83-
System.out.println("Without Custom Proxy In Plugins Tracker");
8482
jenkinsProxy = new JenkinsProxySettings(null);
8583
}
8684

8785
final Proxy proxy = jenkinsProxy.getJenkinsProxy();
8886
if (proxy != Proxy.NO_PROXY) {
89-
System.out.println("Selected some proxy for plugins tracker. " + proxy.toString() + ". And auth: " + jenkinsProxy.hasAuth());
9087
if (jenkinsProxy.hasAuth()) {
9188
final String username = jenkinsProxy.getUsername();
9289
final String password = jenkinsProxy.getPassword();

src/main/java/com/browserstack/automate/ci/common/uploader/AppUploader.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ public String uploadFile()
3636
}
3737

3838
if (proxy.hasProxy()) {
39-
System.out.println("App upload setting proxy for app automate client...");
40-
System.out.println(proxy.getHost() + ":" + proxy.getPort() + "," + proxy.getUsername() + ":" + proxy.getPassword());
4139
appAutomateClient.setProxy(proxy.getHost(), proxy.getPort(), proxy.getUsername(), proxy.getPassword());
4240
}
4341
return appAutomateClient.uploadApp(this.appPath).getAppUrl();

src/main/java/com/browserstack/automate/ci/jenkins/BrowserStackReportForBuild.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ public BrowserStackReportForBuild(final Run<?, ?> build,
6161
this.projectType = projectType;
6262
this.logger = logger;
6363
this.customProxy = customProxy;
64-
System.out.println("Initialized BrowserStackReportForBuild with customProxy: " + this.customProxy);
6564
this.tracker = tracker;
6665
this.pipelineStatus = pipelineStatus;
6766
fetchBuildAndSessions();

src/main/java/com/browserstack/automate/ci/jenkins/pipeline/AppUploadStepExecution.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ protected Void run() throws Exception {
4040
String customProxy = parentContextEnvVars.get("https_proxy");
4141
customProxy = Optional.ofNullable(customProxy).orElse(parentContextEnvVars.get("http_proxy"));
4242

43-
System.out.println("App upload custom proxy: " + customProxy);
4443
String appId = AppUploaderHelper.uploadApp(run, logger, this.appPath, customProxy);
4544

4645
if (StringUtils.isEmpty(appId)) {

src/main/java/com/browserstack/automate/ci/jenkins/pipeline/BrowserStackPipelineStepExecution.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,6 @@ public boolean start() throws Exception {
5555

5656
final PluginsTracker tracker = new PluginsTracker(customProxy);
5757

58-
System.out.println("\ncustomProxy in pipeline execution: " + customProxy);
59-
6058
BrowserStackCredentials credentials =
6159
BrowserStackCredentials.getCredentials(run.getParent(), credentialsId);
6260

src/main/java/com/browserstack/automate/ci/jenkins/pipeline/BrowserStackReportStepExecution.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ protected Void run() throws Exception {
3838

3939
final PluginsTracker tracker = new PluginsTracker(customProxy);
4040

41-
System.out.println("\ncustomProxy in report generation: " + customProxy);
42-
4341
log(logger, "Generating BrowserStack Test Report via Pipeline for : " + product.name());
4442

4543
String browserStackBuildName = parentContextEnvVars.get(BrowserStackEnvVars.BROWSERSTACK_BUILD_NAME);

0 commit comments

Comments
 (0)