Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImagePullSecrets value getting patched/removed to null while creation of lighthousejob for pipelines triggered via jx start pipeline CLI #223

Open
nagenderRawat opened this issue Jan 14, 2021 · 0 comments

Comments

@nagenderRawat
Copy link

nagenderRawat commented Jan 14, 2021

I wanted to use my container images from private ACR repo so therefore I provided docker pull secret under ImagePullSecret in my both pr/release pipeline.yaml, just like below -:

apiVersion: tekton.dev/v1beta1
kind: PipelineRun
spec:
  podTemplate:
    ImagePullSecrets:
    - name: tekton-container-registry-auth

preSubmit/postSubmit pipeline triggered via github webhook event
When the Lighthousejob is created for preSubmit/postSubmit pipeline triggered via github webhook event, it does contains the actual value of ImagePullSecrets provided in the pipeline(pr/release pipeline) definition, just like in above definition, and works fine, No issues.

preSubmit/postSubmit pipeline triggered via jx pipeline start cmd
but when the Lighthousejob created for a preSubmit/postSubmit pipeline(pr/release one), it's not having the original ImagePullSecrets value, instead the value is getting replaced with null(can be seen below ), may be its getting patched somewhere in between LHjob creation.
hence not able to pull containers image form private pvt registry and release pipelines are breaking.

podTemplate:
    ImagePullSecrets: null

if we are triggering pipeline via jx cli than it always has postsubmit Type no matter which --kind you pass as argument to jx pipeline start cmd, so any pipeline(pre/post) triggered using CLI is only having the issue.

JX beta verision -: version: 3.1.120 (with latest gitops upgrade already applied to cluster)

Slack thread for the same https://kubernetes.slack.com/archives/C9MBGQJRH/p1610040745132700
https://kubernetes.slack.com/archives/C9MBGQJRH/p1610220507242100 for more insights on the issue.

@nagenderRawat nagenderRawat changed the title ImagePullSecrets value getting patched/removed to null while creation of lighthousejob for only postsubmit Type pipelines ImagePullSecrets value getting patched/removed to null while creation of lighthousejob for pipelines triggered via jx start pipeline CLI Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant