added TODO

jendakol · jendakol · commit a7439bb9340c · 2019-02-17T22:13:06.000+01:00
changed INNO script output name
diff --git a/app/lib/commands/BackupCommandExecutor.scala b/app/lib/commands/BackupCommandExecutor.scala
@@ -130,6 +130,15 @@ class BackupCommandExecutor @Inject()(bsDao: BackupSetsDao,
     }
   }
 
+  // TODO: corner case - what to do with files from other platforms??
+  //  private def isOtherPlatformFile(f: FileTreeNode): Boolean = {
+  //    if (SystemUtils.IS_OS_WINDOWS) {
+  //      f.path.headOption.contains('/')
+  //    } else if (SystemUtils.IS_OS_UNIX) {
+  //      f.path.headOption.exists(_ != '/')
+  //    } else sys.error("Unsupported platform")
+  //  }
+
   private def updateBackupSetFilesList(bsId: Long, paths: Seq[String]): Result[Unit] = {
     val normalized = normalizePaths(paths)
 
diff --git a/windeploy/rbackup-client.iss b/windeploy/rbackup-client.iss
@@ -18,7 +18,7 @@ AppPublisher={#MyAppPublisher}
 DefaultDirName={pf}\RBackupClient
 DefaultGroupName={#MyAppName}
 DisableProgramGroupPage=yes
-OutputBaseFilename=rbackup-client-setup
+OutputBaseFilename=rbackup-client-setup-{#MyAppVersion}
 Compression=lzma
 SolidCompression=yes
 MinVersion=0,5.01sp3

Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,15 @@ class BackupCommandExecutor @Inject()(bsDao: BackupSetsDao,`
`130`	`130`	`}`
`131`	`131`	`}`
`132`	`132`
	`133`	`+ // TODO: corner case - what to do with files from other platforms??`
	`134`	`+ // private def isOtherPlatformFile(f: FileTreeNode): Boolean = {`
	`135`	`+ // if (SystemUtils.IS_OS_WINDOWS) {`
	`136`	`+ // f.path.headOption.contains('/')`
	`137`	`+ // } else if (SystemUtils.IS_OS_UNIX) {`
	`138`	`+ // f.path.headOption.exists(_ != '/')`
	`139`	`+ // } else sys.error("Unsupported platform")`
	`140`	`+ // }`
	`141`	`+`
`133`	`142`	`private def updateBackupSetFilesList(bsId: Long, paths: Seq[String]): Result[Unit] = {`
`134`	`143`	`val normalized = normalizePaths(paths)`
`135`	`144`