Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(question) Missmatch between the README.md and values.yaml #14

Open
OriolFilter opened this issue Jul 20, 2024 · 2 comments
Open

(question) Missmatch between the README.md and values.yaml #14

OriolFilter opened this issue Jul 20, 2024 · 2 comments

Comments

@OriolFilter
Copy link
Contributor

OriolFilter commented Jul 20, 2024

The values.yaml uses the image tag 10.9.1, and the README.md states latest as default value.

Which value is the right one?

@OriolFilter OriolFilter changed the title Missmatch between the README.md and values.yaml (question) Missmatch between the README.md and values.yaml Jul 20, 2024
@lknite
Copy link

lknite commented Nov 9, 2024

In a home lab you probably want to use 'latest' cause who cares if it crashes, you are there to bring it back to life without anyone being effected ... but in general best practice is to specify the version number, such as in the values.yaml .

This best practice can be seen even more if you google 'kyverno best practices' and look at their best-practices polices, one being to block the 'latest' tag from being used at all. This is a common policy to put into place, and it means if a helm chart such as this one used 'latest' than everyone using that tag with such a policy would experience a broken deployment ... the helm chart needs to specify a version number ... but you don't.

It makes sense for the readme to say latest, that's pretty standard ... cause its an example deployment, and in a test deployment you probably want the latest.

@Supporterino
Copy link
Contributor

Thank you for pointing out the discrepancy, @OriolFilter.

You are correct that there is a mismatch between the values.yaml and the README.md. However, the chart no longer uses latest as the default. Instead, it uses the defined appVersion inside the Chart.yaml. Users also have the option to set a specific version using the image.tag key.

As @lknite mentioned, while using latest might be suitable for a home lab or test deployment, best practices recommend specifying a version number to ensure stability and compatibility, especially in production environments. This is reflected in the use of the appVersion to set the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants