-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(question) Missmatch between the README.md and values.yaml #14
Comments
In a home lab you probably want to use 'latest' cause who cares if it crashes, you are there to bring it back to life without anyone being effected ... but in general best practice is to specify the version number, such as in the values.yaml . This best practice can be seen even more if you google 'kyverno best practices' and look at their best-practices polices, one being to block the 'latest' tag from being used at all. This is a common policy to put into place, and it means if a helm chart such as this one used 'latest' than everyone using that tag with such a policy would experience a broken deployment ... the helm chart needs to specify a version number ... but you don't. It makes sense for the readme to say latest, that's pretty standard ... cause its an example deployment, and in a test deployment you probably want the latest. |
Thank you for pointing out the discrepancy, @OriolFilter. You are correct that there is a mismatch between the As @lknite mentioned, while using |
The values.yaml uses the image tag
10.9.1
, and the README.md stateslatest
as default value.Which value is the right one?
The text was updated successfully, but these errors were encountered: