Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: The attribute image.itemtype has an invalid value. #183

Closed
aav7fl opened this issue Apr 6, 2017 · 1 comment · Fixed by #185
Closed

Warning: The attribute image.itemtype has an invalid value. #183

aav7fl opened this issue Apr 6, 2017 · 1 comment · Fixed by #185

Comments

@aav7fl
Copy link
Contributor

aav7fl commented Apr 6, 2017

Looks like when I removed all of my image changes in #151 (because of #174), I also removed my change that appeased Google's "Warning" The attribute image.itemtype has an invalid value..

We have:

"image": "https://www.kyleniewiada.org/assets/img/2017/02/banner.png",

We should have:

"image": {"@type": "ImageObject",
"url": "https://www.kyleniewiada.org/assets/img/2017/02/banner.png",
"height": 400,
"width": 700},

Hence why we offer the image height and width as options. I can add this back in, but it won't be until the weekend. It's somewhere in one of the older commits for #151, along with some tests.

@aav7fl
Copy link
Contributor Author

aav7fl commented Apr 11, 2017

PR submitted.

benbalter added a commit that referenced this issue Apr 11, 2017
@jekyll jekyll locked and limited conversation to collaborators Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants