added line count method

Author: jegesh

randomAccessReader/__init__.py

@@ -28,6 +28,10 @@ def __init__(self, filepath, endline_character='\n'):
         self._endline = endline_character
         self._lines = self._get_line_data()
 
+    @property
+    def number_of_lines(self):
+        return len(self._lines)
+
     def _get_line_data(self):
         f = open(self._filepath)
         lines = []
@@ -36,15 +40,14 @@ def _get_line_data(self):
         current_line = 0
         while has_more:
             current = f.read(1)
-            if current == '':
-                has_more = False
-                continue
 
-            if current == self._endline:
+            if current == self._endline or current == '':
                 # we've reached the end of the current line
                 lines.append({"position": start_position, "length": current_line})
                 start_position += current_line + 1
                 current_line = 0
+                if current == '':
+                    has_more = False
                 continue
 
             current_line += 1

setup.py

@@ -15,7 +15,7 @@
     # Versions should comply with PEP440.  For a discussion on single-sourcing
     # the version across setup.py and the project code, see
     # https://packaging.python.org/en/latest/single_source_version.html
-    version='0.1.0',
+    version='0.1.1',
 
     description='A python random access file reader',
     long_description=long_description,

tests/tests.py

@@ -11,6 +11,11 @@ def test_text_file(self):
         line = reader.get_line(5)
         self.assertTrue('Learn Tons of Blogging Tips &Tricks' in line)
 
+    def test_line_count(self):
+        path = os.path.dirname(os.path.abspath(__file__)) + "/test_file.csv"
+        reader = RandomAccessReader(path)
+        self.assertTrue(reader.number_of_lines == 34)
+
 
 class CsvReaderTest(unittest.TestCase):