Skip to content

Commit fa1cbfc

Browse files
committed
removed special _fn handling in header -> ScadInterface, better ScadInterface integration
1 parent b5abd32 commit fa1cbfc

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

solid/core/object_base.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,16 @@ def __call__(self, *args):
3737
def __repr__(self):
3838
return self.as_scad()
3939

40-
def as_scad(self, _fn=None):
40+
def as_scad(self, scad_interface=None):
4141
from .scad_render import scad_render
42-
return scad_render(self, _fn=_fn)[:-1]
42+
return scad_render(self, scad_interface=scad_interface)[:-1]
4343

44-
def save_as_scad(self, filename='', outdir='', _fn=None):
44+
def save_as_scad(self, filename='', outdir='', scad_interface=None):
4545
from .scad_render import scad_render_to_file
46-
return scad_render_to_file(self, filename, outdir, _fn=_fn)
46+
return scad_render_to_file(self,
47+
filename,
48+
outdir,
49+
scad_interface=scad_interface)
4750

4851
class OpenSCADObject(ObjectBase):
4952
def __init__(self, name, params):

solid/core/scad_render.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
# =========================================
99
# = Rendering Python code to OpenSCAD code=
1010
# =========================================
11-
def scad_render(root, file_header = '', _fn=None, scad_interface=None):
11+
def scad_render(root, file_header = '', scad_interface=None):
1212
#get a list of all used and included files
1313
includes = get_include_string()
1414

@@ -26,24 +26,21 @@ def scad_render(root, file_header = '', _fn=None, scad_interface=None):
2626
extensions_footer_str = default_extension_manager.call_post_render(root)
2727
extensions_footer_str += "\n" if extensions_footer_str else ''
2828

29-
if _fn:
30-
file_header += f'$fn = {_fn};\n\n'
31-
3229
if scad_interface != None:
3330
file_header += scad_interface.get_header_str()
3431

3532
return file_header + includes + extensions_header_str + scad_body \
3633
+ extensions_footer_str
3734

3835
def scad_render_to_file(scad_object, filename=None, out_dir='',
39-
file_header='', include_orig_code=True, _fn=None,
36+
file_header='', include_orig_code=True,
4037
scad_interface = None):
4138

4239
if out_dir == None:
4340
out_dir = ''
4441
header = f"// Generated by ExpSolidPython\n" + file_header + "\n"
4542

46-
rendered_string = scad_render(scad_object, header, _fn, scad_interface)
43+
rendered_string = scad_render(scad_object, header, scad_interface)
4744

4845
return _write_to_file(rendered_string, filename, out_dir)
4946

solid/examples/11-fonts.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,5 @@
1212
scad = ScadInterface()
1313
scad.register_font("11-font/RichEatin.otf")
1414

15-
t = text(font="Rich Eatin'", text="blablub")
16-
scad_render_to_file(t, scad_interface=scad)
15+
text(font="Rich Eatin'", text="blablub").save_as_scad(scad_interface=scad)
1716

0 commit comments

Comments
 (0)