Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RfC: Making skin labs useful for people who explore skins #13

Open
2 of 4 tasks
alistair3149 opened this issue May 20, 2022 · 6 comments
Open
2 of 4 tasks

RfC: Making skin labs useful for people who explore skins #13

alistair3149 opened this issue May 20, 2022 · 6 comments

Comments

@alistair3149
Copy link

alistair3149 commented May 20, 2022

Please feel free to edit the list, it is a list of potential pain points that help to explore how to make skin labs more useful and desirable for people who explore skins (e.g. wiki admins, extension dev, etc.).

  • As a wiki admin, I want to see a preview of a wiki page in my language, so that I can pick a skin that works with my language (Support different interface languages in preview mode #12).
  • As a wiki admin, I want to see if the skin works with my MW version, so that I know the skin would run on my wiki.
  • As a wiki admin, I want to see how a skin looks with my MW version, so that I know how the skin look on my wiki.
  • As an extension developer, I want to see potential locations that I can add UI elements to with hook, so that I know how my extension look across different skins.

It is a rough draft that I can personally think of for now and had come across before. Looking forward to how you'all think about it!

@jdlrobson
Copy link
Owner

Looking into many of these things today

@alistair3149
Copy link
Author

Looking into many of these things today

Please let me know if there is anything me or the community can chime in. I can't offer much in terms of development other than some styling and basic JS, but it is an awesome project that I really want it to be successful!

@jdlrobson
Copy link
Owner

As an extension developer, I want to see potential locations that I can add UI elements to with hook, so that I know how my extension look across different skins.

Regarding this one installing https://github.com/jdlrobson/mediawiki-skins-skinjson does a lot of this (via wgSkinJSONValidate) and it's enabled on the skins preview on the site. Is there anything specific functionality missing here?

@alistair3149
Copy link
Author

Regarding this one installing https://github.com/jdlrobson/mediawiki-skins-skinjson does a lot of this (via wgSkinJSONValidate) and it's enabled on the skins preview on the site. Is there anything specific functionality missing here?

SkinJson helps skin developers seeing all the Mustache data available but it is not helpful for extension developers seeing how the extension would integrate with the skin in terms of UI. I see that there are already some work done with the Potential banner location. and SkinAfterContent boxes. Would it be possible to link those boxes directly to the manual of the hook or pages related to how to use them?

@jdlrobson
Copy link
Owner

That sounds like a great idea!

jdlrobson added a commit to jdlrobson/mediawiki-skins-skinjson that referenced this issue May 28, 2022
As suggested in
jdlrobson/skins.wmflabs.org#13

Change-Id: Iaa96e74fda83fc1c15be2770d0ff9187603a1c55
jdlrobson added a commit to jdlrobson/mediawiki-skins-skinjson that referenced this issue Nov 19, 2022
As suggested in
jdlrobson/skins.wmflabs.org#13

Change-Id: Iaa96e74fda83fc1c15be2770d0ff9187603a1c55
@jdlrobson
Copy link
Owner

I made a bit of progress on 2. The API at https://skins-demo.wmflabs.org//w/rest.php/v1/skins now surfaces branches which can be used to determine available MediaWiki versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants