Can't get a thumbnail for network stream when running mympd behind nginx reverse proxy #657
-
myMPD version: 0.9.1 (commit 8eaa000) Describe the bug Can't get picture to display for network streams To Reproduce
Open stream https://www.radioking.com/play/radio-doudou I followed the directive in the documentation with regard to how thumbnails should be named on the disk:
I named the thumnail
I even tried with the example stream, with the same result:
Surprisingly, in the debug output there's no mention of any attempt to grab the thumbnail from the Am I missing something obvious ? NB: I also had the same issue with previous versions of mympd. As a matter of fact, I've never been able to get this feature to work, when the thumbnails had to be placed under |
Beta Was this translation helpful? Give feedback.
Replies: 8 comments 1 reply
-
I tested with the same version with Firefox and Chromium and it worked for me. In your log is the stream url wrong: I see you use myMPD behind a reverse proxy. I assume that your reverse proxy changes BTW: you can merge the |
Beta Was this translation helpful? Give feedback.
-
I had noticed the missing slash in the Indeed, I'm running behind an nginx reverse proxy.
I can confirm it works when accessing the webserver directly. |
Beta Was this translation helpful? Give feedback.
-
Replacing Edit: There is a nginx option named |
Beta Was this translation helpful? Give feedback.
-
The Moreover, the nginx documentation recommends not to enable merging slashes for security reasons, but doesn't go into details over what those reasons are. http://nginx.org/en/docs/http/ngx_http_core_module.html#merge_slashes Not sure if we should limit ourselves to documenting the nginx change or process the url with the missing Encoding the url with the |
Beta Was this translation helpful? Give feedback.
-
I think for the moment it is the best to document this. To work around this behavior we should construct the uri differently. My first attempt would be: I will dive deeper into this as soon I implement #439 . |
Beta Was this translation helpful? Give feedback.
-
The double slash issue should be fixed in devel. |
Beta Was this translation helpful? Give feedback.
-
While I can confirm it works for the current playing song, it doesn't seem to be working for the webradios favourites. myMPD version 9.2.0 devel commit d002826 nginx reverse proxy configuration
Enabling or disabling the "merge_slashes" nginx setting does not impact this problem. mympd log when running behind nginx reverse proxy and accessing the webradios favourites page:
Log when accessing mympd directly without reverse proxy
|
Beta Was this translation helpful? Give feedback.
-
I think we should not close discussions. Closed discussions are hidden in the default view. Especially in the Q&A section is the answered label is the better approach. |
Beta Was this translation helpful? Give feedback.
Replacing
//
with/
could be a default uri normalization function of nginx.Edit: There is a nginx option named
merge_slashes
that can be set to off. This could fix this issue.