Scaling background image

[pgzh]

I'd like to suggest a possible enhancement:
If a background image is selected it would be nice if it were scaled to fill the background area completely.

Depending on the width/height ratio, there may be an area above and below or left and right where the bgimage isn't displayed.

If the height of the image is smaller than the display area (or more precisely the width/height ratio of the image is greater than that of the display), maybe it could be scaled to full height and cropped left and right.
If the width is smaller than the display area (width/height ratio smaller than that of the display), it could be scaled to full width and cropped top and bottom.

Especially on mobile devices with rotating displays the whole area would be covered by the bgimage this way.

On top of that it would be really cool if the bgimage would extend to the whole display and the bars at the top and the bottom could be configured with adjustable transparency.

Thanks for making this great mpd client!!

[jcorporation]

The css for the background sizing is:

background-position: center center; 
background-size: contain;  
background-repeat: no-repeat;

Transparency for the toolbars could be an option.

[pgzh]

Hi, thank you for the quick response.
Looking at the css I think
background-size: cover;
may just achieve what I tried to describe.
contain will ensure the whole image is displayed and may add bars, but cover will keep aspect ratio, scale to use all space and avoid bars but instead crop part of the image instead.

So if you'd consider transparency maybe you could also consider a config option to choose between contain and cover for the background-size property?

[jcorporation]

This should be no problem.

[pgzh]

I'd love to see this implemented, thanks for being open to my suggestions!
And one more question: can the css filter applied to the cover art also be applied to the bgimage?

[jcorporation]

I like discussing my project. Feedback is very important for me, thank you. It is so much todo and not so much time...

[jcorporation]

I changed the image background css to cover and fixed with commit 651a69f

[pgzh]

It looks just like I imagined - thank you!
Just to let you know, it seems I cannot enable LUA in the version I built (liblua 5.3 dev package is installed - but it still says "Lua is not compiled in" in the settings page).
I also had to copy the binary manually to /usr/bin, since build.sh pkgdebian failed with:

make[1]: Leaving directory '/root/myMPD/package/build/release'
mkdir -p debian/tmp/DEBIAN
cp debian/postinst debian/tmp/DEBIAN
cp debian/postrm debian/tmp/DEBIAN
cp debian/conffiles debian/tmp/DEBIAN
cp: cannot stat 'debian/conffiles': No such file or directory
make: *** [debian/rules:24: binary-arch] Error 1
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

I'm probably missing a package, but I am not really sure which...

Looking forward to the next stable version with this changes, thanks again :-)

[jcorporation]

The Debian packaging process is broken in the v8.0.0 branch. This will be fixed before releasing it.
Fixed with ea6f8d0

[jcorporation]

Just to let you know, it seems I cannot enable LUA in the version I built (liblua 5.3 dev package is installed - but it still says "Lua is not compiled in" in the settings page).

Please open a bug report for this issue with output of ./build.sh release, debian version, etc.