Prevent negative summaries caused by 0,0 records

- we have recieved completed records with no EndTime,
  this causes there usage to be assigned to Month 0 Year 0.
- This prevents those records being taken into consideration
  by the summariser.
- In all the cases I have seen a valid completed message is
  sent eventually. So this doesnt hide any usage
- Also updates the update script

Author: gregcorbett

schemas/cloud.sql

@@ -294,7 +294,13 @@ BEGIN
 	PrevRecord.MeasurementTime = (SELECT max(MeasurementTime)
                                       FROM CloudRecords
                                       WHERE VMUUID = ThisRecord.VMUUID
-                                      AND MeasurementTime < ThisRecord.MeasurementTime)
+                                      AND MeasurementTime < ThisRecord.MeasurementTime
+                                      -- This prevents negative summaries being caused
+                                      -- by 'completed' records without an EndTime.
+                                      -- Now, such Records are not included in this
+                                      -- LEFT JOIN statement
+                                      AND PrevRecord.MeasurementMonth<>0
+                                      AND PrevRecord.MeasurementYear<>0)
 );
 
     REPLACE INTO CloudSummaries(SiteID, CloudComputeServiceID, Month, Year,

scripts/update_measurememt_time.sql

@@ -174,7 +174,13 @@ BEGIN
         PrevRecord.MeasurementTime = (SELECT max(MeasurementTime)
                                       FROM CloudRecords
                                       WHERE VMUUID = ThisRecord.VMUUID
-                                      AND MeasurementTime < ThisRecord.MeasurementTime)
+                                      AND MeasurementTime < ThisRecord.MeasurementTime
+                                      -- This prevents negative summaries being caused
+                                      -- by 'completed' records without an EndTime.
+                                      -- Now, such Records are not included in this 
+                                      -- LEFT JOIN statement
+                                      AND PrevRecord.MeasurementMonth<>0
+                                      AND PrevRecord.MeasurementYear<>0)
 );
 
     REPLACE INTO CloudSummaries(SiteID, CloudComputeServiceID, Month, Year,