Skip to content

ListField items_types parameter should be required #96

@avrahamshukron

Description

@avrahamshukron

Right now this parameter has a None default value, which means that the actual value will be an empty tuple.

This creates inconsistent behavior:

class Foo(Base):
    l = ListField()  # Look ma, no `items_types`!

f = Foo()
f.l.append("a")  # works

# But look at this:
f = Foo(l=["a"])
Traceback (most recent call last):
 ...
ValidationError: Cannot decide which type to choose from "".

Inconsistency: Validation during __init__ is not the same as when using append.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions