Support explicit integer padding in lax.conv_transpose #32268
+43
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
samanklesaria
changed the title
samanklesaria
changed the title
samanklesaria
force-pushed
the
issues/32267
branch
from
c1afc19 to
a04ab03
Compare
samanklesaria
force-pushed
the
issues/32267
branch
from
a04ab03 to
fcfeec2
Compare
samanklesaria
force-pushed
the
issues/32267
branch
from
fcfeec2 to
08335fa
Compare
levskaya
approved these changes
Oct 8, 2025
Collaborator
levskaya
left a comment
levskaya
left a comment
There was a problem hiding this comment.
I think this all looks right! apologies for the slow review.
google-ml-butler
bot
added
kokoro:force-run
pull ready
samanklesaria
force-pushed
the
issues/32267
branch
from
08335fa to
9d85343
Compare
levskaya
approved these changes
Oct 23, 2025
samanklesaria
force-pushed
the
issues/32267
branch
from
9d85343 to
1e460b4
Compare
levskaya
approved these changes
Oct 30, 2025
samanklesaria
force-pushed
the
issues/32267
branch
3 times, most recently
from
94309d5 to
6637697
Compare
samanklesaria
force-pushed
the
issues/32267
branch
from
6637697 to
cac0151
Compare
samanklesaria
force-pushed
the
issues/32267
branch
from
cac0151 to
597e739
Compare
yashk2810
reviewed
Nov 25, 2025
| preferred_element_type: DTypeLike | None = None) -> Array: | ||
| preferred_element_type: DTypeLike | None = None, | ||
| use_consistent_padding: bool = False, | ||
| out_sharding: NamedSharding | P | None = None) -> Array: |
Collaborator
There was a problem hiding this comment.
Why are you adding out_sharding here?
Collaborator
There was a problem hiding this comment.
Please remove it since out_sharding has nothing to do with the bug you are trying to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of integer padding arguments to
lax.conv_transpose. It addresses #32267 and google/flax#4593 by computing the padding necessary for a conv-transpose when the input padding argument is interpreted as the padding used by the ordinary convolution, as described in https://arxiv.org/abs/1603.07285