Skip to content

Commit ccc2973

Browse files
committed
Fixed test
1 parent a005c11 commit ccc2973

File tree

2 files changed

+15
-15
lines changed
  • src
    • main/java/g3501_3600/s3580_find_consistently_improving_employees
    • test/java/g3501_3600/s3580_find_consistently_improving_employees

2 files changed

+15
-15
lines changed

src/main/java/g3501_3600/s3580_find_consistently_improving_employees/script.sql

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,21 @@
22
# #Medium #Database #2025_06_11_Time_449_ms_(91.67%)_Space_0.0_MB_(100.00%)
33
WITH Ranked AS (
44
SELECT
5-
employee_id,
6-
name,
7-
review_date,
8-
rating,
5+
e.employee_id,
6+
e.name,
7+
pr.review_date,
8+
pr.rating,
99
RANK() OVER (
10-
PARTITION BY employee_id
11-
ORDER BY review_date DESC
10+
PARTITION BY e.employee_id
11+
ORDER BY pr.review_date DESC
1212
) AS rnk,
13-
LAG(rating) OVER (
14-
PARTITION BY employee_id
15-
ORDER BY review_date DESC
16-
) AS lag_rating
17-
FROM employees
18-
LEFT JOIN performance_reviews
19-
USING (employee_id)
13+
LAG(pr.rating) OVER (
14+
PARTITION BY e.employee_id
15+
ORDER BY pr.review_date DESC
16+
) AS lag_rating
17+
FROM employees e
18+
LEFT JOIN performance_reviews pr
19+
ON e.employee_id = pr.employee_id
2020
)
2121
SELECT
2222
employee_id,
@@ -29,7 +29,7 @@ GROUP BY
2929
name
3030
HAVING
3131
COUNT(*) = 3
32-
AND SUM(lag_rating > rating) = 2
32+
AND SUM(CASE WHEN lag_rating > rating THEN 1 ELSE 0 END) = 2
3333
ORDER BY
3434
improvement_score DESC,
3535
name ASC;

src/test/java/g3501_3600/s3580_find_consistently_improving_employees/MysqlTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ void testScript(@EmbeddedDatabase DataSource dataSource)
7373
assertThat(resultSet.getNString(3), equalTo("2"));
7474
assertThat(resultSet.next(), equalTo(true));
7575
assertThat(resultSet.getNString(1), equalTo("3"));
76-
assertThat(resultSet.getNString(2), equalTo("Alice Johnson"));
76+
assertThat(resultSet.getNString(2), equalTo("Carol Davis"));
7777
assertThat(resultSet.getNString(3), equalTo("2"));
7878
assertThat(resultSet.next(), equalTo(false));
7979
}

0 commit comments

Comments
 (0)