Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized rendering #32

Open
edparcell opened this issue Aug 30, 2024 · 1 comment
Open

Generalized rendering #32

edparcell opened this issue Aug 30, 2024 · 1 comment

Comments

@edparcell
Copy link
Contributor

Right now, rendering is two phase - phase one converts the networkx graph that represents a loman computation into a networkx graph that represents that graphical rendering. Phase two converts the networkx graph to a pydot object that can be used to run graphviz.

I think the phase one can be restructured into two parts, which can be Abstract classes that can implement different things. One part selects the nodes and edges to be drawn. The second decides how to render a particular node or edge. So.... one SelectionStrategy might be "given me everything within distance two of a particular node. And one DrawingMethod might be "make the dataframes square and scalars circles, loman computations are stars and other objects diamonds. DrawingMethods probably stack.

@edparcell
Copy link
Contributor Author

edparcell commented Oct 29, 2024

The drawing method part is implemented in d53587e

@edparcell edparcell reopened this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant