Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Assignment1 task 2 #2

Closed
rferens opened this issue Mar 6, 2020 · 1 comment
Closed

Typo in Assignment1 task 2 #2

rferens opened this issue Mar 6, 2020 · 1 comment

Comments

@rferens
Copy link

rferens commented Mar 6, 2020

[1p] Prepare the data for logistic regression: Map the sentiment scores $0,1,2,3,4$ to a probability of the sentence being by setting $p(\textrm{positive}) = \textrm{sentiment}/4$. Build a dictionary of at most 20000 most frequent words.

Should the bolded fragment be "sentence being positive"? It that probability a purpose of our logistic regression prediction(i.e. do we reduce orginally stated problem with scale 0-4 to just positive/negative classification)?

Morover, it seems that there is less than 20000 words in that sentences.

@janchorowski
Copy link
Owner

Yes about the typo, please submit a PR.
WRT the number of words, that's great then, you can add an "if needed phrase", it is good practice to know the vocab size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants