Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong number of words in assignment 1 #1

Closed
inverb opened this issue Feb 27, 2020 · 1 comment
Closed

Wrong number of words in assignment 1 #1

inverb opened this issue Feb 27, 2020 · 1 comment

Comments

@inverb
Copy link

inverb commented Feb 27, 2020

In task 2 from assignment 1 it says that ws should " Build a dictionary of most frequent 20000 words." Yet in all of the 8529 sentences there are only about 18000 distinct words. Should that number be 2000?

@janchorowski
Copy link
Owner

No, I didn't count the words and wanted to somehow limit the number. For the last point you can check the influence of vocab size.

janchorowski added a commit that referenced this issue Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants