Merge pull request #4 from milesstanfield/standard-1-37-0

standard-1-37-0

Author: milesstanfield

Dockerfile

@@ -9,7 +9,7 @@ RUN adduser -u 9000 -g 9000 -D app
 COPY Gemfile Gemfile.lock /usr/src/app/
 
 RUN apk add --update build-base && \
-    gem install bundler && \
+    gem install bundler -v 2.4.22 && \
     bundle install --quiet -j 4 --without=test && \
     chown -R app:app /usr/local/bundle && \
     rm -fr ~/.gem ~/.bundle ~/.wh..gem && \

Gemfile

@@ -2,10 +2,10 @@ source "https://rubygems.org"
 
 gem "activesupport", require: false
 gem "mry", "~> 0.52.0", require: false
-gem "parser", "~> 3.0.2"
+gem "parser", "~> 3.3.0"
 gem "pry", require: false
 gem "safe_yaml"
-gem "standard", "~> 1.4", require: false
+gem "standard", "1.37.0", require: false
 
 group :test do
   gem "rake"

Gemfile.lock

@@ -13,20 +13,25 @@ GEM
     diff-lcs (1.4.4)
     i18n (1.8.10)
       concurrent-ruby (~> 1.0)
+    json (2.8.2)
+    language_server-protocol (3.17.0.3)
+    lint_roller (1.1.0)
     method_source (1.0.0)
     minitest (5.14.4)
     mry (0.52.0.0)
       rubocop (>= 0.41.0)
-    parallel (1.21.0)
-    parser (3.0.3.1)
+    parallel (1.26.3)
+    parser (3.3.6.0)
       ast (~> 2.4.1)
+      racc
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    rainbow (3.0.0)
+    racc (1.8.1)
+    rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.1.1)
-    rexml (3.2.5)
+    regexp_parser (2.9.2)
+    rexml (3.3.9)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
@@ -40,28 +45,39 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
-    rubocop (1.22.3)
+    rubocop (1.64.1)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.12.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.13.0)
-      parser (>= 3.0.1.1)
-    rubocop-performance (1.11.5)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
-    ruby-progressbar (1.11.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.36.1)
+      parser (>= 3.3.1.0)
+    rubocop-performance (1.21.1)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
+    ruby-progressbar (1.13.0)
     safe_yaml (1.0.5)
-    standard (1.4.0)
-      rubocop (= 1.22.3)
-      rubocop-performance (= 1.11.5)
+    standard (1.37.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.64.0)
+      standard-custom (~> 1.0.0)
+      standard-performance (~> 1.4)
+    standard-custom (1.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.50)
+    standard-performance (1.4.0)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.21.0)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.1.0)
+    unicode-display_width (2.6.0)
     zeitwerk (2.4.2)
 
 PLATFORMS
@@ -70,12 +86,12 @@ PLATFORMS
 DEPENDENCIES
   activesupport
   mry (~> 0.52.0)
-  parser (~> 3.0.2)
+  parser (~> 3.3.0)
   pry
   rake
   rspec
   safe_yaml
-  standard (~> 1.4)
+  standard (= 1.37.0)
 
 BUNDLED WITH
    2.1.4

README.md

@@ -11,7 +11,12 @@ You can find some basic setup instructions and links to the Standard OSS project
 ### Installation
 
 1. If you haven't already, [install the Code Climate CLI](https://github.com/codeclimate/codeclimate).
-2. Add the engine and enable it in your `.codeclimate.yml` file.
+2. Enable the engine by adding the following under `plugins` in your `.codeclimate.yaml`:
+    ```yaml
+    plugins:
+      standard:
+        enabled: true
+    ```
 3. You're ready to analyze! Browse into your project's folder and run `codeclimate analyze`.
 
 ### Need help?

config/contents/bundler/duplicated_gem.md

@@ -1,4 +1,5 @@
 A Gem's requirements should be listed only once in a Gemfile.
+
 ### Example:
     # bad
     gem 'rubocop'

config/contents/bundler/duplicated_group.md

@@ -0,0 +1,51 @@
+A Gem group, or a set of groups, should be listed only once in a Gemfile.
+
+For example, if the values of `source`, `git`, `platforms`, or `path`
+surrounding `group` are different, no offense will be registered:
+
+[source,ruby]
+-----
+platforms :ruby do
+    group :default do
+      gem 'openssl'
+    end
+end
+
+platforms :jruby do
+    group :default do
+      gem 'jruby-openssl'
+    end
+end
+-----
+
+### Example:
+    # bad
+    group :development do
+      gem 'rubocop'
+    end
+
+    group :development do
+      gem 'rubocop-rails'
+    end
+
+    # bad (same set of groups declared twice)
+    group :development, :test do
+      gem 'rubocop'
+    end
+
+    group :test, :development do
+      gem 'rspec'
+    end
+
+    # good
+    group :development do
+      gem 'rubocop'
+    end
+
+    group :development, :test do
+      gem 'rspec'
+    end
+
+    # good
+    gem 'rubocop', groups: [:development, :test]
+    gem 'rspec', groups: [:development, :test]

config/contents/bundler/gem_filename.md

@@ -0,0 +1,22 @@
+Verifies that a project contains Gemfile or gems.rb file and correct
+associated lock file based on the configuration.
+
+### Example: EnforcedStyle: Gemfile (default)
+    # bad
+    Project contains gems.rb and gems.locked files
+
+    # bad
+    Project contains Gemfile and gems.locked file
+
+    # good
+    Project contains Gemfile and Gemfile.lock
+
+### Example: EnforcedStyle: gems.rb
+    # bad
+    Project contains Gemfile and Gemfile.lock files
+
+    # bad
+    Project contains gems.rb and Gemfile.lock file
+
+    # good
+    Project contains gems.rb and gems.locked files

config/contents/bundler/insecure_protocol_source.md

@@ -1,15 +1,18 @@
-The symbol argument `:gemcutter`, `:rubygems`, and `:rubyforge`
-are deprecated. So please change your source to URL string that
-'https://rubygems.org' if possible, or 'http://rubygems.org' if not.
+Passing symbol arguments to `source` (e.g. `source :rubygems`) is
+deprecated because they default to using HTTP requests. Instead, specify
+`'https://rubygems.org'` if possible, or `'http://rubygems.org'` if not.
 
-This autocorrect will replace these symbols with 'https://rubygems.org'.
-Because it is secure, HTTPS request is strongly recommended. And in
-most use cases HTTPS will be fine.
+When autocorrecting, this cop will replace symbol arguments with
+`'https://rubygems.org'`.
 
-However, it don't replace all `sources` of `http://` with `https://`.
-For example, when specifying an internal gem server using HTTP on the
-intranet, a use case where HTTPS cannot be specified was considered.
-Consider using HTTP only if you cannot use HTTPS.
+This cop will not replace existing sources that use `http://`. This may
+be necessary where HTTPS is not available. For example, where using an
+internal gem server via an intranet, or where HTTPS is prohibited.
+However, you should strongly prefer `https://` where possible, as it is
+more secure.
+
+If you don't allow `http://`, please set `false` to `AllowHttpProtocol`.
+This option is `true` by default for safe autocorrection.
 
 ### Example:
     # bad
@@ -19,4 +22,13 @@ Consider using HTTP only if you cannot use HTTPS.
 
     # good
     source 'https://rubygems.org' # strongly recommended
-    source 'http://rubygems.org'
+
+### Example: AllowHttpProtocol: true (default)
+
+    # good
+    source 'http://rubygems.org' # use only if HTTPS is unavailable
+
+### Example: AllowHttpProtocol: false
+
+    # bad
+    source 'http://rubygems.org'

config/contents/bundler/ordered_gems.md

@@ -14,7 +14,15 @@ Gems should be alphabetically sorted within groups.
 
     gem 'rspec'
 
-    # good only if TreatCommentsAsGroupSeparators is true
+### Example: TreatCommentsAsGroupSeparators: true (default)
+    # good
+    # For code quality
+    gem 'rubocop'
+    # For tests
+    gem 'rspec'
+
+### Example: TreatCommentsAsGroupSeparators: false
+    # bad
     # For code quality
     gem 'rubocop'
     # For tests

config/contents/gemspec/date_assignment.md

@@ -0,0 +1,46 @@
+Enforce that gem dependency version specifications or a commit reference (branch,
+ref, or tag) are either required or forbidden.
+
+### Example: EnforcedStyle: required (default)
+
+    # bad
+    Gem::Specification.new do |spec|
+      spec.add_dependency 'parser'
+    end
+
+    # bad
+    Gem::Specification.new do |spec|
+      spec.add_development_dependency 'parser'
+    end
+
+    # good
+    Gem::Specification.new do |spec|
+      spec.add_dependency 'parser', '>= 2.3.3.1', '< 3.0'
+    end
+
+    # good
+    Gem::Specification.new do |spec|
+      spec.add_development_dependency 'parser', '>= 2.3.3.1', '< 3.0'
+    end
+
+### Example: EnforcedStyle: forbidden
+
+    # bad
+    Gem::Specification.new do |spec|
+      spec.add_dependency 'parser', '>= 2.3.3.1', '< 3.0'
+    end
+
+    # bad
+    Gem::Specification.new do |spec|
+      spec.add_development_dependency 'parser', '>= 2.3.3.1', '< 3.0'
+    end
+
+    # good
+    Gem::Specification.new do |spec|
+      spec.add_dependency 'parser'
+    end
+
+    # good
+    Gem::Specification.new do |spec|
+      spec.add_development_dependency 'parser'
+    end

config/contents/gemspec/dependency_version.md

@@ -0,0 +1,21 @@
+Checks that deprecated attributes are not set in a gemspec file.
+Removing deprecated attributes allows the user to receive smaller packed gems.
+
+### Example:
+
+    # bad
+    Gem::Specification.new do |spec|
+      spec.name = 'your_cool_gem_name'
+      spec.test_files = Dir.glob('test/**/*')
+    end
+
+    # bad
+    Gem::Specification.new do |spec|
+      spec.name = 'your_cool_gem_name'
+      spec.test_files += Dir.glob('test/**/*')
+    end
+
+    # good
+    Gem::Specification.new do |spec|
+      spec.name = 'your_cool_gem_name'
+    end