Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to include confidence intervals? #39

Open
jsimons8 opened this issue Apr 29, 2024 · 2 comments
Open

Is it possible to include confidence intervals? #39

jsimons8 opened this issue Apr 29, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jsimons8
Copy link

Some regression coefficients cannot have a standard error in the usual sense but should come with intervals instead. Is it possible to construct those in place of SEs with TexTables?

@jacobadenbaum
Copy link
Owner

jacobadenbaum commented Apr 29, 2024

I'm not going to have time to work on this in the near future (see the note on this package's maintenance status in the readme) but I think this seems quite sensible, and I'll be happy to review/merge a PR that implements this so long as its tested properly and doesn't break any existing tests.

If anyone is interested in making a PR for this, my guess is that there's a couple of things that need to be done

  1. You probably want to make a new type (or update the existing one) of FNumSE to accommodate a range for the CI, rather than be hardcoded as a single number for the SE, as it is done currently. My guess is that a new type would be the easiest approach, as then it can all just be done by multiple dispatch, and you define the custom printing for se(x::FNumCI) like you can see here
  2. Then, I think all you'll need to do is update the StatsModel interface here to take an additional option
    • this probably requires updating the setcoef! function here
    • which relies on the setindex! logic for tables, so you can either construct the CI as an FNumCI there, or add extra dispatch logic directly here
  3. Then you'll need to see if it works (I may have missed something here -- it's been a long time since I wrote this code), make sure you haven't broken the existing tests, and write some new tests for the existing functionality. A lot of the tests for a package like this are done using hardcoded table examples, which it needs to replicate exactly. I have some helper functions to manage these table examples in the test suite which you might helpful.

@jacobadenbaum jacobadenbaum added the enhancement New feature or request label Apr 29, 2024
@jsimons8
Copy link
Author

jsimons8 commented Apr 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants