Address analyzer warning in NBRegularExpressionCache

LowAmmo · LowAmmo · commit 90510c99ebd1 · 2025-10-29T16:34:09.000-05:00
diff --git a/Package.swift b/Package.swift
@@ -14,7 +14,7 @@ let package = Package(
         .target(
             name: "libPhoneNumber",
             path: "libPhoneNumber",
-            exclude: ["GeneratePhoneNumberHeader.sh", "Info.plist"],
+            exclude: ["Info.plist"],
             publicHeadersPath: ".",
             cSettings: [
                 .headerSearchPath("Internal")
diff --git a/Package@swift-5.0.swift b/Package@swift-5.0.swift
@@ -20,7 +20,7 @@ let package = Package(
         .target(
             name: "libPhoneNumber",
             path: "libPhoneNumber",
-            exclude: ["GeneratePhoneNumberHeader.sh", "Info.plist"],
+            exclude: ["Info.plist"],
             publicHeadersPath: ".",
             cSettings: [
                 .headerSearchPath("Internal")
diff --git a/Package@swift-5.5.swift b/Package@swift-5.5.swift
@@ -21,7 +21,7 @@ let package = Package(
         .target(
             name: "libPhoneNumber",
             path: "libPhoneNumber",
-            exclude: ["GeneratePhoneNumberHeader.sh", "Info.plist"],
+            exclude: ["Info.plist"],
             publicHeadersPath: ".",
             cSettings: [
                 .headerSearchPath("Internal")
diff --git a/libPhoneNumber/Internal/NBRegularExpressionCache.m b/libPhoneNumber/Internal/NBRegularExpressionCache.m
@@ -46,7 +46,7 @@ - (NSRegularExpression *)regularExpressionForPattern:(NSString *)pattern error:(
     NSRegularExpression *regEx = [[NSRegularExpression alloc] initWithPattern:pattern
                                                                       options:kNilOptions
                                                                         error:&regExError];
-    if (regEx == nil && error != nil) {
+    if (regEx == nil) {
       if (error != NULL) {
         *error = regExError;
       }

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ - (NSRegularExpression )regularExpressionForPattern:(NSString )pattern error:(`
`46`	`46`	`NSRegularExpression *regEx = [[NSRegularExpression alloc] initWithPattern:pattern`
`47`	`47`	`options:kNilOptions`
`48`	`48`	`error:&regExError];`
`49`		`- if (regEx == nil && error != nil) {`
	`49`	`+ if (regEx == nil) {`
`50`	`50`	`if (error != NULL) {`
`51`	`51`	`*error = regExError;`
`52`	`52`	`}`