From 0213cce97228ab37074ecc60acd829d79187a9ce Mon Sep 17 00:00:00 2001 From: NoLifeKing Date: Wed, 18 Oct 2023 18:47:47 +0200 Subject: [PATCH 1/5] fix(EDDN): Remove properties from ApproachSettlementEvents --- Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs b/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs index f94edad..082a1f9 100644 --- a/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs +++ b/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs @@ -33,6 +33,12 @@ public enum RequiredProperties public enum RemoveProperties { + StationGovernment, + StationEconomies, + StationFaction, + StationServices, + StationEconomy, + StationAllegiance, } } } From 2b0a81872833bfaadf6d64758341a1968af679c1 Mon Sep 17 00:00:00 2001 From: NoLifeKing Date: Wed, 18 Oct 2023 18:56:41 +0200 Subject: [PATCH 2/5] fix(EDDN): The properties will be allowed soon! Waiting for https://github.com/EDCD/EDDN/pull/215 to be merged --- Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs b/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs index 082a1f9..f94edad 100644 --- a/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs +++ b/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs @@ -33,12 +33,6 @@ public enum RequiredProperties public enum RemoveProperties { - StationGovernment, - StationEconomies, - StationFaction, - StationServices, - StationEconomy, - StationAllegiance, } } } From 84b501da8934ccac0df9ca672552331ce8464086 Mon Sep 17 00:00:00 2001 From: NoLifeKing Date: Sat, 21 Oct 2023 12:19:22 +0200 Subject: [PATCH 3/5] fix: Remove StationAllegiance from ApproachSettlement --- Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs b/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs index f94edad..c288d17 100644 --- a/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs +++ b/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs @@ -33,6 +33,7 @@ public enum RequiredProperties public enum RemoveProperties { + StationAllegiance } } } From 8921567dec6a877f547d7de0e5782c40d0eb89db Mon Sep 17 00:00:00 2001 From: NoLifeKing Date: Sat, 21 Oct 2023 13:42:29 +0200 Subject: [PATCH 4/5] fix(EDDN): Remove FactionState as well. --- Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs b/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs index c288d17..7c94984 100644 --- a/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs +++ b/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs @@ -33,7 +33,8 @@ public enum RequiredProperties public enum RemoveProperties { - StationAllegiance + StationAllegiance, + FactionState } } } From 7cf21adc182936e8bba76c7f69436a0108e2fa83 Mon Sep 17 00:00:00 2001 From: NoLifeKing Date: Mon, 23 Oct 2023 13:28:51 +0200 Subject: [PATCH 5/5] fix: Stop removing `FactionState` and `StationAllegiance` --- Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs b/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs index 7c94984..f94edad 100644 --- a/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs +++ b/Journal-Limpet.Shared/EDDN/ApproachSettlementEvents.cs @@ -33,8 +33,6 @@ public enum RequiredProperties public enum RemoveProperties { - StationAllegiance, - FactionState } } }