Skip to content

Commit 7346c14

Browse files
authored
Merge pull request #135 from /issues/134
[Bug]: not set Clickhouse userName and password have npe #134
2 parents 1a1b2a7 + 9bc4e3e commit 7346c14

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

flink-connector-clickhouse/src/main/java/org/apache/flink/connector/clickhouse/internal/connection/ClickHouseConnectionProvider.java

+8-4
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,14 @@ private ClickHouseConnection createConnection(String url, String database) throw
128128
LOG.info("connecting to {}, database {}", url, database);
129129
Properties configuration = new Properties();
130130
configuration.putAll(connectionProperties);
131-
configuration.setProperty(
132-
ClickHouseDefaults.USER.getKey(), options.getUsername().orElse(null));
133-
configuration.setProperty(
134-
ClickHouseDefaults.PASSWORD.getKey(), options.getPassword().orElse(null));
131+
if (options.getUsername().isPresent()) {
132+
configuration.setProperty(
133+
ClickHouseDefaults.USER.getKey(), options.getUsername().get());
134+
}
135+
if (options.getPassword().isPresent()) {
136+
configuration.setProperty(
137+
ClickHouseDefaults.PASSWORD.getKey(), options.getPassword().get());
138+
}
135139
ClickHouseDriver driver = new ClickHouseDriver();
136140
return driver.connect(url, configuration);
137141
}

pom.xml

+3-3
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ limitations under the License.
5858

5959
<properties>
6060
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
61-
<maven.compiler.source>11</maven.compiler.source>
62-
<maven.compiler.target>11</maven.compiler.target>
61+
<maven.compiler.source>8</maven.compiler.source>
62+
<maven.compiler.target>8</maven.compiler.target>
6363
<junit.version>4.13.2</junit.version>
64-
<clickhouse-jdbc.version>0.6.0-patch3</clickhouse-jdbc.version>
64+
<clickhouse-jdbc.version>0.6.1</clickhouse-jdbc.version>
6565
<scala.binary.version>2.12</scala.binary.version>
6666
<flink.version>1.19.0</flink.version>
6767
<flink.scope>provided</flink.scope>

0 commit comments

Comments
 (0)