Fixed the display of checkboxes at 100% width

DEVSIX-5571

Author: Evgeniy Prudnikov

src/main/java/com/itextpdf/html2pdf/attach/impl/layout/form/renderer/AbstractFormFieldRenderer.java

@@ -231,7 +231,9 @@ protected boolean isRendererFit(float availableWidth, float availableHeight) {
         if (occupiedArea == null) {
             return false;
         }
-        return availableHeight >= occupiedArea.getBBox().getHeight() && availableWidth >= occupiedArea.getBBox().getWidth();
+        return availableHeight >= occupiedArea.getBBox().getHeight() &&
+                ((availableWidth >= occupiedArea.getBBox().getWidth()) ||
+                        (this.<OverflowPropertyValue>getProperty(Property.OVERFLOW_X) == OverflowPropertyValue.VISIBLE));
     }
 
     /**

src/main/java/com/itextpdf/html2pdf/attach/impl/layout/form/renderer/CheckBoxRenderer.java

@@ -57,6 +57,7 @@ This file is part of the iText (R) project.
 import com.itextpdf.layout.borders.SolidBorder;
 import com.itextpdf.layout.element.Paragraph;
 import com.itextpdf.layout.layout.LayoutContext;
+import com.itextpdf.layout.properties.HorizontalAlignment;
 import com.itextpdf.layout.properties.Property;
 import com.itextpdf.layout.renderer.DrawContext;
 import com.itextpdf.layout.renderer.IRenderer;
@@ -95,7 +96,8 @@ protected IRenderer createFlatRenderer() {
                 .setWidth(DEFAULT_SIZE)
                 .setHeight(DEFAULT_SIZE)
                 .setBorder(new SolidBorder(DEFAULT_BORDER_COLOR, DEFAULT_BORDER_WIDTH))
-                .setBackgroundColor(DEFAULT_BACKGROUND_COLOR);
+                .setBackgroundColor(DEFAULT_BACKGROUND_COLOR)
+                .setHorizontalAlignment(HorizontalAlignment.CENTER);
         return new FlatParagraphRenderer(paragraph);
     }
 

src/test/java/com/itextpdf/html2pdf/element/InputTest.java

@@ -271,13 +271,43 @@ public void checkboxTaggingTest() throws IOException, InterruptedException {
     }
 
     @Test
-    // TODO DEVSIX-5571 Update cmp after the ticket is closed
-    @LogMessages(ignore = true, messages = {
-            @LogMessage(messageTemplate = LayoutLogMessageConstant.ELEMENT_DOES_NOT_FIT_AREA),
-            @LogMessage(messageTemplate = Html2PdfLogMessageConstant.INPUT_FIELD_DOES_NOT_FIT),
-    })
+    public void checkboxInTableTest() throws IOException, InterruptedException {
+        runTest("checkboxInTable");
+    }
+
+    @Test
+    public void checkboxDisplayBlockInTableTest() throws IOException, InterruptedException {
+        runTest("checkboxDisplayBlockInTable");
+    }
+
+    @Test
+    public void checkboxFullWidthDisplayBlockInTableTest() throws IOException, InterruptedException {
+        runTest("checkboxFullWidthDisplayBlockInTable");
+    }
+
+    @Test
+    public void checkboxDiffWidthDisplayBlockInTableTest() throws IOException, InterruptedException {
+        runTest("checkboxDiffWidthDisplayBlockInTable");
+    }
+
+    @Test
+    public void checkboxTest() throws IOException, InterruptedException {
+        runTest("checkbox");
+    }
+
+    @Test
+    public void checkboxDisplayBlockTest() throws IOException, InterruptedException {
+        runTest("checkboxDisplayBlock");
+    }
+
+    @Test
     public void checkboxFullWidthDisplayBlockTest() throws IOException, InterruptedException {
-        runTest("checkboxFullWidthDisplayBlockTest");
+        runTest("checkboxFullWidthDisplayBlock");
+    }
+
+    @Test
+    public void checkboxDiffWidthDisplayBlockTest() throws IOException, InterruptedException {
+        runTest("checkboxDiffWidthDisplayBlock");
     }
 
     @Test

src/test/java/com/itextpdf/html2pdf/element/TableTest.java

@@ -532,11 +532,6 @@ public void checkResponsiveTableExample() throws IOException, InterruptedExcepti
     }
 
     @Test
-    @LogMessages(messages = {
-            @LogMessage(messageTemplate = LayoutLogMessageConstant.ELEMENT_DOES_NOT_FIT_AREA, count = 2),
-            @LogMessage(messageTemplate = Html2PdfLogMessageConstant.INPUT_FIELD_DOES_NOT_FIT, count = 2),
-    })
-    //TODO: DEVSIX-3022 - Inputs bigger than enclosing cell force table to split
     public void tableWithChildrenBiggerThanCellTest() throws IOException, InterruptedException {
         runTest("tableWithChildrenBiggerThanCell");
     }

src/test/resources/com/itextpdf/html2pdf/element/InputTest/checkbox.html

@@ -0,0 +1,8 @@
+<!DOCTYPE html>
+<html>
+<body>
+<div style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+    <input type="checkbox" value="true"/>
+</div>
+</body>
+</html>

src/test/resources/com/itextpdf/html2pdf/element/InputTest/checkboxDiffWidthDisplayBlock.html

@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html>
+<body>
+
+<div style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+    <input type="checkbox" style="width: 50%; display: block;" value="true"/>
+</div>
+
+
+<div style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+    <input type="checkbox" style="width: 100%; display: block;" value="true"/>
+</div>
+
+
+<div style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+    <input type="checkbox" style="width: 200%; display: block;" value="true"/>
+</div>
+
+
+</body>
+</html>

src/test/resources/com/itextpdf/html2pdf/element/InputTest/checkboxDiffWidthDisplayBlockInTable.html

@@ -0,0 +1,29 @@
+<!DOCTYPE html>
+<html>
+<body>
+<table style="border-width: 0px; padding: 0px; margin: 0px; border-spacing: 0px;">
+  <tr>
+    <td style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+      <input type="checkbox" style="width: 50%; display: block;" value="true"/>
+    </td>
+  </tr>
+</table>
+
+<table style="border-width: 0px; padding: 0px; margin: 0px; border-spacing: 0px;">
+  <tr>
+    <td style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+      <input type="checkbox" style="width: 100%; display: block;" value="true"/>
+    </td>
+  </tr>
+</table>
+
+<table style="border-width: 0px; padding: 0px; margin: 0px; border-spacing: 0px;">
+  <tr>
+    <td style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+      <input type="checkbox" style="width: 200%; display: block;" value="true"/>
+    </td>
+  </tr>
+</table>
+
+</body>
+</html>

src/test/resources/com/itextpdf/html2pdf/element/InputTest/checkboxDisplayBlock.html

@@ -0,0 +1,8 @@
+<!DOCTYPE html>
+<html>
+<body>
+<div style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+    <input type="checkbox" style="display: block;" value="true"/>
+</div>
+</body>
+</html>

src/test/resources/com/itextpdf/html2pdf/element/InputTest/checkboxDisplayBlockInTable.html

@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+<body>
+<table style="border-width: 0px; padding: 0px; margin: 0px; border-spacing: 0px;">
+  <tr>
+    <td style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+      <input type="checkbox" style="display: block;" value="true"/>
+    </td>
+  </tr>
+</table>
+</body>
+</html>

src/test/resources/com/itextpdf/html2pdf/element/InputTest/checkboxFullWidthDisplayBlock.html

@@ -0,0 +1,8 @@
+<!DOCTYPE html>
+<html>
+<body>
+<div style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+    <input type="checkbox" style="width: 100%; display: block;" value="true"/>
+</div>
+</body>
+</html>

src/test/resources/com/itextpdf/html2pdf/element/InputTest/checkboxFullWidthDisplayBlockTest.html renamed to src/test/resources/com/itextpdf/html2pdf/element/InputTest/checkboxFullWidthDisplayBlockInTable.html

@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+<body>
+<table style="border-width: 0px; padding: 0px; margin: 0px; border-spacing: 0px;">
+    <tr>
+        <td style="background-color: red; border-width: 0px;  padding: 0px; margin: 0px;">
+            <input type="checkbox" value="true"/>
+        </td>
+    </tr>
+</table>
+</body>
+</html>