Skip to content

Commit 69a8e21

Browse files
committed
Revise destination name generation mechanism when building outlines
Previously, prefix was duplicated which resulted in named like "pdfHTML-iText-outline-pdfHTML-iText-outline-1" DEVSIX-3495
1 parent d0f3df0 commit 69a8e21

File tree

9 files changed

+3
-3
lines changed

9 files changed

+3
-3
lines changed

src/main/java/com/itextpdf/html2pdf/attach/impl/OutlineHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ public String getDestinationNamePrefix() {
214214
* @return the unique destination name
215215
*/
216216
protected String generateUniqueDestinationName(IElementNode element) {
217-
return destinationNamePrefix + getUniqueID(destinationNamePrefix);
217+
return getUniqueID(destinationNamePrefix);
218218
}
219219

220220
/**

src/test/java/com/itextpdf/html2pdf/attach/impl/OutlineHandlerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public void defaultDestinationPrefixTest() {
6969
PdfOutline pdfOutline = context.getPdfDocument().getOutlines(false).getAllChildren().get(0);
7070
Assert.assertEquals("p1", pdfOutline.getTitle());
7171
PdfString pdfStringDest = (PdfString) pdfOutline.getDestination().getPdfObject();
72-
Assert.assertEquals("pdfHTML-iText-outline-pdfHTML-iText-outline-1", pdfStringDest.toUnicodeString());
72+
Assert.assertEquals("pdfHTML-iText-outline-1", pdfStringDest.toUnicodeString());
7373
}
7474

7575
@Test
@@ -96,6 +96,6 @@ public void customDestinationPrefixTest() {
9696
PdfOutline pdfOutline = context.getPdfDocument().getOutlines(false).getAllChildren().get(0);
9797
Assert.assertEquals("p1", pdfOutline.getTitle());
9898
PdfString pdfStringDest = (PdfString) pdfOutline.getDestination().getPdfObject();
99-
Assert.assertEquals("prefix-prefix-1", pdfStringDest.toUnicodeString());
99+
Assert.assertEquals("prefix-1", pdfStringDest.toUnicodeString());
100100
}
101101
}
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)