Skip to content

[12.0] saas_portal: Migrate to v12.0 #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 12.0
Choose a base branch
from
Open

[12.0] saas_portal: Migrate to v12.0 #822

wants to merge 1 commit into from

Conversation

@hieuhani
Copy link

@hieuhani hieuhani commented Dec 19, 2018 •
edited
Loading

Hi,

I've migrated saas_portal to 12:

  • Import _tz_get from correct package
  • Rename async to asynchronous to avoid reversed keyword
  • Add name to group filter to valid the xml
  • Add aria-label and title to button class that are using fontawesome to fix the warnings.

Regards,

yelizariev
yelizariev reviewed Dec 24, 2018
View reviewed changes
@FFernandez-PlanetaTIC FFernandez-PlanetaTIC mentioned this pull request Jan 24, 2019
Open
@GSLabIt
Copy link

GSLabIt commented Feb 21, 2019

Hi there, any eta for this one?

@ilmir-k ilmir-k mentioned this pull request Apr 3, 2019
Closed
@ilmir-k ilmir-k mentioned this pull request May 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yelizariev yelizariev yelizariev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hieuhani @GSLabIt @yelizariev