Skip to content

Commit e3c5b91

Browse files
committed
Some corrections
* Remove subset notes * Add source_* notes
1 parent 9026218 commit e3c5b91

File tree

7 files changed

+33
-7
lines changed

7 files changed

+33
-7
lines changed

networking/v1alpha3/destination_rule.proto

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,6 @@ message DestinationRule {
174174

175175
// One or more named sets that represent individual versions of a
176176
// service. Traffic policies can be overridden at subset level.
177-
// Note that subsets are not support in ambient mode.
178-
// Define multiple services instead.
179177
repeated Subset subsets = 3;
180178

181179
// A list of namespaces to which this destination rule is exported.
@@ -320,8 +318,6 @@ message TrafficPolicy {
320318
// **Note:** Policies specified for subsets will not take effect until
321319
// a route rule explicitly sends traffic to this subset.
322320
//
323-
// **Note:** Subsets are not supported in ambient mode. Define multiple services instead.
324-
//
325321
// One or more labels are typically required to identify the subset destination,
326322
// however, when the corresponding DestinationRule represents a host that
327323
// supports multiple SNI hosts (e.g., an egress gateway), a subset without labels

networking/v1alpha3/service_entry.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/service_entry.pb.html

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/service_entry.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ message ServiceEntry {
465465
// service accounts associated with the pods of the service, the
466466
// SANs specified here will also be verified.
467467
//
468-
// **NOTE 3:** Wildcard hostnames are not support in ambient mode.
468+
// **NOTE 3:** Wildcard hostnames are not supported in ambient mode.
469469
//
470470
// +kubebuilder:validation:MinItems=1
471471
// +kubebuilder:validation:MaxItems=256

networking/v1alpha3/virtual_service.pb.go

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.pb.html

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.proto

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -818,6 +818,8 @@ message HTTPMatchRequest {
818818
//
819819
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
820820
// VirtualService applies to.
821+
//
822+
// **Note:** Ambient mode does not support this field.
821823
map<string, string> source_labels = 7;
822824

823825
// Names of gateways where the rule should be applied. Gateway names
@@ -859,6 +861,8 @@ message HTTPMatchRequest {
859861
//
860862
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
861863
// VirtualService applies to.
864+
//
865+
// **Note:** Ambient mode does not support this field.
862866
string source_namespace = 13;
863867

864868
// The human readable prefix to use when emitting statistics for this route.
@@ -990,6 +994,8 @@ message L4MatchAttributes {
990994
//
991995
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
992996
// VirtualService applies to.
997+
//
998+
// **Note:** Ambient mode does not support this field.
993999
map<string, string> source_labels = 4;
9941000

9951001
// Names of gateways where the rule should be applied. Gateway names
@@ -1003,6 +1009,8 @@ message L4MatchAttributes {
10031009
//
10041010
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
10051011
// VirtualService applies to.
1012+
//
1013+
// **Note:** Ambient mode does not support this field.
10061014
string source_namespace = 6;
10071015
}
10081016

@@ -1034,6 +1042,8 @@ message TLSMatchAttributes {
10341042
//
10351043
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
10361044
// VirtualService applies to.
1045+
//
1046+
// **Note:** Ambient mode does not support this field.
10371047
map<string, string> source_labels = 5;
10381048

10391049
// Names of gateways where the rule should be applied. Gateway names
@@ -1047,6 +1057,8 @@ message TLSMatchAttributes {
10471057
//
10481058
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
10491059
// VirtualService applies to.
1060+
//
1061+
// **Note:** Ambient mode does not support this field.
10501062
string source_namespace = 7;
10511063
}
10521064

0 commit comments

Comments
 (0)