Skip to content

Commit ca9ed35

Browse files
committed
Some corrections
* Remove subset notes * Add source_* notes
1 parent 75d0516 commit ca9ed35

File tree

7 files changed

+33
-7
lines changed

7 files changed

+33
-7
lines changed

networking/v1alpha3/destination_rule.proto

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,6 @@ message DestinationRule {
174174

175175
// One or more named sets that represent individual versions of a
176176
// service. Traffic policies can be overridden at subset level.
177-
// Note that subsets are not support in ambient mode.
178-
// Define multiple services instead.
179177
repeated Subset subsets = 3;
180178

181179
// A list of namespaces to which this destination rule is exported.
@@ -320,8 +318,6 @@ message TrafficPolicy {
320318
// **Note:** Policies specified for subsets will not take effect until
321319
// a route rule explicitly sends traffic to this subset.
322320
//
323-
// **Note:** Subsets are not supported in ambient mode. Define multiple services instead.
324-
//
325321
// One or more labels are typically required to identify the subset destination,
326322
// however, when the corresponding DestinationRule represents a host that
327323
// supports multiple SNI hosts (e.g., an egress gateway), a subset without labels

networking/v1alpha3/service_entry.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/service_entry.pb.html

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/service_entry.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ message ServiceEntry {
466466
// service accounts associated with the pods of the service, the
467467
// SANs specified here will also be verified.
468468
//
469-
// **NOTE 3:** Wildcard hostnames are not support in ambient mode.
469+
// **NOTE 3:** Wildcard hostnames are not supported in ambient mode.
470470
//
471471
// +kubebuilder:validation:MinItems=1
472472
// +kubebuilder:validation:MaxItems=256

networking/v1alpha3/virtual_service.pb.go

Lines changed: 12 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.pb.html

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/virtual_service.proto

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -820,6 +820,8 @@ message HTTPMatchRequest {
820820
//
821821
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
822822
// VirtualService applies to.
823+
//
824+
// **Note:** Ambient mode does not support this field.
823825
map<string, string> source_labels = 7;
824826

825827
// Names of gateways where the rule should be applied. Gateway names
@@ -861,6 +863,8 @@ message HTTPMatchRequest {
861863
//
862864
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
863865
// VirtualService applies to.
866+
//
867+
// **Note:** Ambient mode does not support this field.
864868
string source_namespace = 13;
865869

866870
// The human readable prefix to use when emitting statistics for this route.
@@ -992,6 +996,8 @@ message L4MatchAttributes {
992996
//
993997
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
994998
// VirtualService applies to.
999+
//
1000+
// **Note:** Ambient mode does not support this field.
9951001
map<string, string> source_labels = 4;
9961002

9971003
// Names of gateways where the rule should be applied. Gateway names
@@ -1005,6 +1011,8 @@ message L4MatchAttributes {
10051011
//
10061012
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
10071013
// VirtualService applies to.
1014+
//
1015+
// **Note:** Ambient mode does not support this field.
10081016
string source_namespace = 6;
10091017
}
10101018

@@ -1036,6 +1044,8 @@ message TLSMatchAttributes {
10361044
//
10371045
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
10381046
// VirtualService applies to.
1047+
//
1048+
// **Note:** Ambient mode does not support this field.
10391049
map<string, string> source_labels = 5;
10401050

10411051
// Names of gateways where the rule should be applied. Gateway names
@@ -1049,6 +1059,8 @@ message TLSMatchAttributes {
10491059
//
10501060
// **Note:** This is not a runtime match, but is a selector; it filters which workloads the
10511061
// VirtualService applies to.
1062+
//
1063+
// **Note:** Ambient mode does not support this field.
10521064
string source_namespace = 7;
10531065
}
10541066

0 commit comments

Comments
 (0)