Skip to content

Commit e00ccd0

Browse files
chore(tests): simplify get_platform test
`nest_asyncio` is archived and broken on some platforms so it's not worth keeping in our test suite.
1 parent d5732d5 commit e00ccd0

File tree

3 files changed

+6
-49
lines changed

3 files changed

+6
-49
lines changed

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ dev-dependencies = [
5656
"dirty-equals>=0.6.0",
5757
"importlib-metadata>=6.7.0",
5858
"rich>=13.7.1",
59-
"nest_asyncio==1.6.0",
6059
"pytest-xdist>=3.6.1",
6160
]
6261

requirements-dev.lock

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ multidict==6.4.4
7575
mypy==1.14.1
7676
mypy-extensions==1.0.0
7777
# via mypy
78-
nest-asyncio==1.6.0
7978
nodeenv==1.8.0
8079
# via pyright
8180
nox==2023.4.22

tests/test_client.py

Lines changed: 6 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,10 @@
66
import os
77
import sys
88
import json
9-
import time
109
import asyncio
1110
import inspect
12-
import subprocess
1311
import tracemalloc
1412
from typing import Any, Union, cast
15-
from textwrap import dedent
1613
from unittest import mock
1714
from typing_extensions import Literal
1815

@@ -23,14 +20,17 @@
2320

2421
from isaacus import Isaacus, AsyncIsaacus, APIResponseValidationError
2522
from isaacus._types import Omit
23+
from isaacus._utils import asyncify
2624
from isaacus._models import BaseModel, FinalRequestOptions
2725
from isaacus._exceptions import IsaacusError, APIStatusError, APITimeoutError, APIResponseValidationError
2826
from isaacus._base_client import (
2927
DEFAULT_TIMEOUT,
3028
HTTPX_DEFAULT_TIMEOUT,
3129
BaseClient,
30+
OtherPlatform,
3231
DefaultHttpxClient,
3332
DefaultAsyncHttpxClient,
33+
get_platform,
3434
make_request_options,
3535
)
3636

@@ -1669,50 +1669,9 @@ def retry_handler(_request: httpx.Request) -> httpx.Response:
16691669

16701670
assert response.http_request.headers.get("x-stainless-retry-count") == "42"
16711671

1672-
def test_get_platform(self) -> None:
1673-
# A previous implementation of asyncify could leave threads unterminated when
1674-
# used with nest_asyncio.
1675-
#
1676-
# Since nest_asyncio.apply() is global and cannot be un-applied, this
1677-
# test is run in a separate process to avoid affecting other tests.
1678-
test_code = dedent("""
1679-
import asyncio
1680-
import nest_asyncio
1681-
import threading
1682-
1683-
from isaacus._utils import asyncify
1684-
from isaacus._base_client import get_platform
1685-
1686-
async def test_main() -> None:
1687-
result = await asyncify(get_platform)()
1688-
print(result)
1689-
for thread in threading.enumerate():
1690-
print(thread.name)
1691-
1692-
nest_asyncio.apply()
1693-
asyncio.run(test_main())
1694-
""")
1695-
with subprocess.Popen(
1696-
[sys.executable, "-c", test_code],
1697-
text=True,
1698-
) as process:
1699-
timeout = 10 # seconds
1700-
1701-
start_time = time.monotonic()
1702-
while True:
1703-
return_code = process.poll()
1704-
if return_code is not None:
1705-
if return_code != 0:
1706-
raise AssertionError("calling get_platform using asyncify resulted in a non-zero exit code")
1707-
1708-
# success
1709-
break
1710-
1711-
if time.monotonic() - start_time > timeout:
1712-
process.kill()
1713-
raise AssertionError("calling get_platform using asyncify resulted in a hung process")
1714-
1715-
time.sleep(0.1)
1672+
async def test_get_platform(self) -> None:
1673+
platform = await asyncify(get_platform)()
1674+
assert isinstance(platform, (str, OtherPlatform))
17161675

17171676
async def test_proxy_environment_variables(self, monkeypatch: pytest.MonkeyPatch) -> None:
17181677
# Test that the proxy environment variables are set correctly

0 commit comments

Comments
 (0)