Skip to content
This repository was archived by the owner on Dec 13, 2019. It is now read-only.

Commit 0372ba0

Browse files
quentin-stirozgar
authored andcommitted
Fix GulpRevVersionStrategy->manifestFilename not being used (#12)
Deleted class member, now generating manifestFilename when the exception is thrown using basename. fixes #10
1 parent b025376 commit 0372ba0

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

Asset/GulpRevVersionStrategy.php

+2-3
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
*/
1919
class GulpRevVersionStrategy implements VersionStrategyInterface
2020
{
21-
private $manifestFilename;
22-
2321
private $manifestPath;
2422

2523
private $paths = array();
@@ -78,12 +76,13 @@ private function getAssetVersion($path)
7876
private function loadManifestFile()
7977
{
8078
$manifestPath = $this->kernelRootDir.'/'.$this->manifestPath;
79+
$manifestFilename = basename($manifestPath);
8180

8281
if (!is_file($manifestPath)) {
8382
throw new Exception(
8483
sprintf(
8584
'Manifest file "%s" not found in path "%s". You can generate this file running gulp',
86-
$this->manifestFilename, $this->manifestPath
85+
$manifestFilename, $this->manifestPath
8786
)
8887
);
8988
}

0 commit comments

Comments
 (0)