Switch tags with no values to use nil rather than true

Author: DanielOaks

test.go

@@ -183,7 +183,7 @@ Options:
 					continue
 				}
 
-				if value == true {
+				if value == nil {
 					if tag.HasValue {
 						fmt.Println(
 							"Tag",
@@ -248,7 +248,7 @@ Options:
 			if test.Atoms.Tags != nil {
 				tagsDict := make(map[string]ircmsg.TagValue)
 				for key, value := range test.Atoms.Tags {
-					if value == true {
+					if value == nil {
 						tagsDict[key] = ircmsg.NoTagValue()
 					} else {
 						tagsDict[key] = ircmsg.MakeTagValue(value.(string))

tests/msg-join.yaml

@@ -21,7 +21,7 @@
 tests:
   # the atoms dict has the keys:
   #   * tags: tags dict
-  #       tags with no equals sign have a value of true in this file
+  #       tags with no equals sign have a value of null in this file
   #       tags with no value after = sign have a value of empty string
   #   * source: source string, without single leading colon
   #   * verb: verb string
@@ -135,6 +135,18 @@ tests:
       - ":coolguy foo bar baz :  "
 
   # with tags
+  - atoms:
+      tags:
+        "asd": null
+      source: "coolguy"
+      verb: "foo"
+      params:
+        - "bar"
+        - "baz"
+        - "  "
+    matches:
+      - "@asd :coolguy foo bar baz :  "
+
   - atoms:
       verb: "foo"
       tags:

tests/msg-split.yaml

@@ -28,7 +28,7 @@ tests:
 
   # the atoms dict has the keys:
   #   * tags: tags dict
-  #       tags with no equals sign have a value of true in this file
+  #       tags with no equals sign have a value of null in this file
   #       tags with no value after = sign have a value of empty string
   #   * source: source string, without single leading colon
   #   * verb: verb string
@@ -134,7 +134,7 @@ tests:
       tags:
         "a": "b"
         "c": "32"
-        "k": true
+        "k": null
         "rt": "ql7"
 
   # with escaped tags
@@ -150,7 +150,7 @@ tests:
   - input: "@c;h=;a=b :quux ab cd"
     atoms:
       tags:
-        "c": true
+        "c": null
         "h": ""
         "a": "b"
       source: "quux"
@@ -214,9 +214,9 @@ tests:
     atoms:
       tags:
         tag1: "value1"
-        tag2: true
+        tag2: null
         vendor1/tag3: "value2"
-        vendor2/tag4: true
+        vendor2/tag4: null
       source: "irc.example.com"
       verb: "COMMAND"
       params:
@@ -237,9 +237,9 @@ tests:
     atoms:
       tags:
         tag1: "value1"
-        tag2: true
+        tag2: null
         vendor1/tag3: "value2"
-        vendor2/tag4: true
+        vendor2/tag4: null
       verb: "COMMAND"
       params:
         - "param1"