-
Notifications
You must be signed in to change notification settings - Fork 330
Open
Labels
P1High: Likely tackled by core team if no one steps upHigh: Likely tackled by core team if no one steps upeffort/daysEstimated to take multiple days, but less than a weekEstimated to take multiple days, but less than a weekexp/intermediatePrior experience is likely helpfulPrior experience is likely helpfulkind/maintenanceWork required to avoid breaking changes or harm to project's status quoWork required to avoid breaking changes or harm to project's status quo
Description
Is your feature request related to a problem? Please describe.
As part of #1092, we now have capability to reload the pages that failed to load because the gateway was offline. The check involves matching tab titles to validate if the page has content or did it fail. While this works, it won't work with non-english browsers or break in the future because the browsers could change the wording. I would like to improve the functionality to something like what @lidel suggested in the thread.
Describe the solution you'd like
- Attach a listener to
onErrorOccurredfromsrc/lib/ipfs-request.js. - Add
isRecoverableViaOnlineApiwhich stores failed requests to local gateway in a cache similar toerrorInFlight. - Then, I could check if url is present in that cache, removing the need for matching titles.
Describe alternatives you've considered
An implementation using title matching has been provided in #1092.
Additional context
- Discussion: feat: reload failed IPFS tabs when API becomes available #1092 (review)
- Follow Up to: Reload failed IPFS tabs when API becomes available #1010
- Initial PR: feat: reload failed IPFS tabs when API becomes available #1092
Additional tasks
- add tests for local subdomain gateway:
.ipns.localhost:8080and for.ipfs.localhost:8080
Metadata
Metadata
Assignees
Labels
P1High: Likely tackled by core team if no one steps upHigh: Likely tackled by core team if no one steps upeffort/daysEstimated to take multiple days, but less than a weekEstimated to take multiple days, but less than a weekexp/intermediatePrior experience is likely helpfulPrior experience is likely helpfulkind/maintenanceWork required to avoid breaking changes or harm to project's status quoWork required to avoid breaking changes or harm to project's status quo