Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit 3913d68

Browse files
committed
test: last assertions are fine in js-ipfs
1 parent 437eac8 commit 3913d68

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

src/pubsub.js

+5-10
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ module.exports = (common) => {
113113
expect(msg).to.have.property('seqno')
114114
expect(Buffer.isBuffer(msg.seqno)).to.be.eql(true)
115115
expect(msg).to.have.property('topicCIDs').eql([topic])
116-
// TODO: broken https://github.com/ipfs/go-ipfs/issues/3522
117-
// expect(msg).to.have.property('from', ipfs1.peerId.id)
116+
expect(msg).to.have.property('from', ipfs1.peerId.id)
118117

119118
ipfs1.pubsub.unsubscribe(topic, handler)
120119

@@ -351,16 +350,14 @@ module.exports = (common) => {
351350

352351
const sub1 = (msg) => {
353352
expect(msg.data.toString()).to.be.eql(expectedString)
354-
// TODO: Reenable when go-ipfs is unbroken
355-
// expect(msg.from).to.be.eql(ipfs2.peerId.id)
353+
expect(msg.from).to.be.eql(ipfs2.peerId.id)
356354
ipfs1.pubsub.unsubscribe(topic, sub1)
357355
check()
358356
}
359357

360358
const sub2 = (msg) => {
361359
expect(msg.data.toString()).to.be.eql(expectedString)
362-
// TODO: reenable when go-ipfs is unbroken
363-
// expect(msg.from).to.be.eql(ipfs2.peerId.id)
360+
expect(msg.from).to.be.eql(ipfs2.peerId.id)
364361
ipfs2.pubsub.unsubscribe(topic, sub2)
365362
check()
366363
}
@@ -393,15 +390,13 @@ module.exports = (common) => {
393390

394391
function sub1 (msg) {
395392
inbox1.push(msg.data.toString())
396-
// TODO: enable when go-ipfs is unbroken
397-
// expect(msg.from).to.be.eql(ipfs2.peerId.id)
393+
expect(msg.from).to.be.eql(ipfs2.peerId.id)
398394
check()
399395
}
400396

401397
function sub2 (msg) {
402398
inbox2.push(msg.data.toString())
403-
// TODO: enable when go-ipfs is unbroken
404-
// expect(msg.from).to.be.eql(ipfs2.peerId.id)
399+
expect(msg.from).to.be.eql(ipfs2.peerId.id)
405400
check()
406401
}
407402

0 commit comments

Comments
 (0)