Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP 0100: remove batch balancer-related functionality #1108

Closed
tediou5 opened this issue Feb 25, 2025 · 3 comments · Fixed by #1109
Closed

FIP 0100: remove batch balancer-related functionality #1108

tediou5 opened this issue Feb 25, 2025 · 3 comments · Fixed by #1109
Labels
enhancement New feature or request

Comments

@tediou5
Copy link
Collaborator

tediou5 commented Feb 25, 2025

描述 / Description

完成标准 / Done Criteria

  1. Remove batch balancer, associated config and branching logic
  2. Aggregate where possible, batch otherwise where possibleAggregation constraints remain:
  • For ProveCommitAggregate and ProveCommitSectors3, the minimum sectors for aggregation is 4 and the maximum is 819
  • For ProveCommitSectorsNI (Non-Interactive) the minimum sectors for aggregation is 1 and the maximum is 65

Decision matrix should now be:

  • PreCommit: prefer batching wherever possible
  • Commit:
    • Prefer aggregation on commit where there are at least 4 sectors available for a single commit
    • Otherwise batch where possible

Why Important

See https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0100.md#change-motivation

@tediou5 tediou5 added the enhancement New feature or request label Feb 25, 2025
@BigLep BigLep moved this to ⌨️ In Progress in nv25 Track Board Feb 25, 2025
@BigLep BigLep moved this from ⌨️ In Progress to 🐱 Todo in nv25 Track Board Feb 26, 2025
@BigLep
Copy link

BigLep commented Feb 26, 2025

@tediou5 : FYI that we updated the done criteria in filecoin-project/lotus#12902 to provide more specifics.

@tediou5
Copy link
Collaborator Author

tediou5 commented Feb 27, 2025

@tediou5 : FYI that we updated the done criteria in filecoin-project/lotus#12902 to provide more specifics.

@BigLep Nice, let me copy it over.

@BigLep
Copy link

BigLep commented Mar 18, 2025

PR to address this issue: #1109

@github-project-automation github-project-automation bot moved this from 🐱 Todo to 🎉 Done in nv25 Track Board Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants