Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open discussion for the design of the this package #2

Open
ipa-nhg opened this issue Jun 3, 2020 · 3 comments
Open

Open discussion for the design of the this package #2

ipa-nhg opened this issue Jun 3, 2020 · 3 comments
Assignees

Comments

@ipa-nhg
Copy link
Member

ipa-nhg commented Jun 3, 2020

@ipa-hsd @chcorbato
As discussed I created this new repository to hold the python interpreters of my ROS models. This contribution makes possible to use my DSLs and the obtained models from the Tooling out-of the eclipse environment.

For the first version of the package I copied the original rossystem parser from rosgraph_monitor (thanks @ipa-hsd) and added a new parser for ros model with the same base functionalities.

Ideally the rosgraph_observer will be updated to use the code from this package and the parse.py will be removed from rosgraph_monitor, to avoid duplicated code.

It will also be great if we collect here all the python scripts used to parser, interpret or make whatever use of my models and, if possible, unify all in a single base class to make easier the maintenance of the package for me.

What do you think? do you have some special request? which functionalities should be supported apart of get the interfaces from a model? how should be given the output?

See as reference the example: https://github.com/ipa320/ros_model_parser/blob/master/scripts/ros_parser_example.py

@chcorbato
Copy link

chcorbato commented Jun 4, 2020

This is a great idea @ipa-nhg

I am not too familiar with model parsers and I do not want to come here with specific requests for metacontrol. But I will review our work in the paper and use it as a use-case to derive some desired features.

For me, this is something similar to the Owlready2 API to manage OWL models. Maybe that can also give you some inspiration for the ros_model_parser. Actually, maybe you would like to go beyond parsing and provide a more complete library to handle RosModel models. But this really depends on what your future plans for RosModel are.

Feel free to assign this to me so that I cannot forget to contribute here!

@ipa-nhg
Copy link
Member Author

ipa-nhg commented Jun 8, 2020

@chcorbato thanks a lot for the pointer, for sure OwlReady2 is a solution to be inspected, and probably taken as example.

Let see how much time and resources I can use for this parser. As soon as I have time I will try to write down the ideas I have and the potential applications I see that can server as starting point for an open discussion.

In the meanwhile, @chcorbato feel free to comment, add special requests or just ideas of NiceToHave to facilitate the integration of the Ros model with your approach.

@hsd-dev
Copy link
Collaborator

hsd-dev commented Apr 20, 2021

Ideally the rosgraph_observer will be updated to use the code from this package and the parse.py will be removed from rosgraph_monitor, to avoid duplicated code.

see ipa320/rosgraph_monitor#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants