Delete dock and fix potential corruption state issue (#4581)

Author: CoderZhi

action/protocol/dock.go

@@ -46,7 +46,7 @@ func (imsm *inMemStateManager) States(...StateOption) (uint64, state.Iterator, e
 	return 0, nil, nil
 }
 
-func (imsm *inMemStateManager) ReadView(string) (interface{}, error) {
+func (imsm *inMemStateManager) ReadView(string) (View, error) {
 	return nil, nil
 }
 
@@ -88,7 +88,7 @@ func (imsm *inMemStateManager) DelState(opts ...StateOption) (uint64, error) {
 	return 0, nil
 }
 
-func (imsm *inMemStateManager) WriteView(string, interface{}) error {
+func (imsm *inMemStateManager) WriteView(string, View) error {
 	return nil
 }
 

action/protocol/dock_test.go

@@ -70,7 +70,7 @@ type (
 		Height() (uint64, error)
 		State(interface{}, ...StateOption) (uint64, error)
 		States(...StateOption) (uint64, state.Iterator, error)
-		ReadView(string) (interface{}, error)
+		ReadView(string) (View, error)
 	}
 
 	// StateManager defines the stateDB interface atop IoTeX blockchain
@@ -82,17 +82,7 @@ type (
 		// General state
 		PutState(interface{}, ...StateOption) (uint64, error)
 		DelState(...StateOption) (uint64, error)
-		WriteView(string, interface{}) error
-		Dock
-	}
-
-	// Dock defines an interface for protocol to read/write their private data in StateReader/Manager
-	// data are stored as interface{}, user needs to type-assert on their own upon Unload()
-	Dock interface {
-		ProtocolDirty(string) bool
-		Load(string, string, interface{}) error
-		Unload(string, string, interface{}) error
-		Reset()
+		WriteView(string, View) error
 	}
 )
 

action/protocol/kvstorefortrie_test.go

@@ -21,6 +21,8 @@ import (
 var (
 	// ErrUnimplemented indicates a method is not implemented yet
 	ErrUnimplemented = errors.New("method is unimplemented")
+	// ErrNoName indicates the name is not found
+	ErrNoName = errors.New("name is not found")
 )
 
 const (
@@ -39,7 +41,7 @@ type Protocol interface {
 
 // Starter starts the protocol
 type Starter interface {
-	Start(context.Context, StateReader) (interface{}, error)
+	Start(context.Context, StateReader) (View, error)
 }
 
 // GenesisStateCreator creates some genesis states
@@ -100,22 +102,55 @@ func BlobGasFeeOption(blobGasFee *big.Int) DepositOption {
 	}
 }
 
-// DepositGas deposits gas to rewarding pool and burns baseFee
-type DepositGas func(context.Context, StateManager, *big.Int, ...DepositOption) ([]*action.TransactionLog, error)
+type (
+	// DepositGas deposits gas to rewarding pool and burns baseFee
+	DepositGas func(context.Context, StateManager, *big.Int, ...DepositOption) ([]*action.TransactionLog, error)
+
+	View interface {
+		Clone() View
+		Snapshot() int
+		Revert(int) error
+		Commit(context.Context, StateReader) error
+	}
+
+	// Views stores the view for all protocols
+	Views struct {
+		vm map[string]View
+	}
+)
 
-// View stores the view for all protocols
-type View map[string]interface{}
+func NewViews() *Views {
+	return &Views{
+		vm: make(map[string]View),
+	}
+}
 
-func (view View) Read(name string) (interface{}, error) {
-	if v, hit := view[name]; hit {
+func (views *Views) Clone() *Views {
+	clone := NewViews()
+	for key, view := range views.vm {
+		clone.vm[key] = view.Clone()
+	}
+	return clone
+}
+
+func (views *Views) Commit(ctx context.Context, sr StateReader) error {
+	for _, view := range views.vm {
+		if err := view.Commit(ctx, sr); err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
+func (views *Views) Read(name string) (View, error) {
+	if v, hit := views.vm[name]; hit {
 		return v, nil
 	}
 	return nil, ErrNoName
 }
 
-func (view View) Write(name string, v interface{}) error {
-	view[name] = v
-	return nil
+func (views *Views) Write(name string, v View) {
+	views.vm[name] = v
 }
 
 // HashStringToAddress generates the contract address from the protocolID of each protocol